Git Product home page Git Product logo

Comments (9)

AlexTMjugador avatar AlexTMjugador commented on August 20, 2024 1

Is there an issue filed upstream w/ zopfli itself?

No, there isn't, but that paperwork is not necessary because I'm a maintainer of that library, and I've just pushed a change that I believe will fix this issue: zopfli-rs/zopfli@fcfb76c.

I'll test the fix with OxiPNG for a bit to confirm that the attached images are working fine now.

from oxipng.

Maingron avatar Maingron commented on August 20, 2024 1

@AlexTMjugador didn't get any errors so far. Also tried a 5760x2160 image, although I don't know if that one would have thrown an error.

from oxipng.

Maingron avatar Maingron commented on August 20, 2024

Noticed the same on Windows 10. Think this only applies to high-resolution images.

from oxipng.

AlexTMjugador avatar AlexTMjugador commented on August 20, 2024

I'm sorry about the issue. It's caused due to the zopfli version bump to 0.7, which contains a regression that is generating corrupt streams (I can reproduce corruption problems by using the zopfli binary on the attached image). I'll try to dig further in it.

from oxipng.

TPS avatar TPS commented on August 20, 2024

Is there an issue filed upstream w/ zopfli itself?

from oxipng.

Maingron avatar Maingron commented on August 20, 2024

For your testing, here are some more images that failed on me. Weirdly it's not applying to all image of the same source.
Failing images for testing (issue 449).zip

Edit: Note that, at least I think so, the images got compressed with an older version, so you might see a 0,00% reduction.

from oxipng.

Maingron avatar Maingron commented on August 20, 2024

If you provide a compiled version, I can run tests too. I got the error on quite many images.

from oxipng.

AlexTMjugador avatar AlexTMjugador commented on August 20, 2024

Here it is a Windows build of the changes I'm testing. I've cross-compiled it from my Linux workstation and it seems to work well enough to show usage help under Wine: oxipng.zip

Edit: the problematic image attached by the issue poster has just been optimized successfully for me. Other images attached by @Maingron worked fine, too.

from oxipng.

AlexTMjugador avatar AlexTMjugador commented on August 20, 2024

Thank you all for your input 😄

I've just submitted a PR that should fix the issue.

from oxipng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.