Git Product home page Git Product logo

Comments (5)

hype09 avatar hype09 commented on August 20, 2024 1

I think I might've found a way where we don't need a custom event: we can probably just use the native reset event on forms.

The AJAX form-cms-handler.plugin.js could trigger a form reset (this.el.reset()) after submission, which even makes some sense semantically... the form is submitted via AJAX, and then the form itself is reset.

The form-preserver.plugin.js can then just clear the local storage on both submit and reset (which kind-of makes sense in any case - if a form is reset, we probably don't want to keep the information in local storage, anyway).

This way, we'd keep both plugins nicely uncoupled - what do you think?

from platform.

mitelg avatar mitelg commented on August 20, 2024 1

I am not the JS pro, but sounds reasonable for me 😁

if you like, you can put that into a PR and let's see what our frontend guys think about that 🙂

from platform.

mitelg avatar mitelg commented on August 20, 2024 1

fixed with #3753

from platform.

shopware-issue-bot avatar shopware-issue-bot commented on August 20, 2024

We found the following existing issues which may help or are related to your topic:

from platform.

mitelg avatar mitelg commented on August 20, 2024

Maybe we can introduce an event, that other JS plugins can emit and the preserver plugin is listening to. so custom submit-like stuff could also be handled.

from platform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.