Rack 3.1 added validation against PATH_INFO . That's f

There is extra handling for OPTION * added in <a cla

Arf, there's also a problem with chunked encoding: <div class="snippet-clipboard-c

Test failure against Rack 3.1 about pitchfork HOT 5 CLOSED

Earlopain commented on August 19, 2024

Test failure against Rack 3.1

from pitchfork.

Comments (5)

casperisfine commented on August 19, 2024

IMO this is a bug on rack side. OPTIONS * HTTP/1.1 is valid HTTP by the spec: https://datatracker.ietf.org/doc/html/rfc7231#section-4.3.7

from pitchfork.

Earlopain commented on August 19, 2024

There is extra handling for OPTION * added in rack/rack#2114, perhaps it contains some useful info for you.

Maybe that PR did it wrong?

from pitchfork.

casperisfine commented on August 19, 2024

Right, it's because it was previously seen as invalid by Rack, so the parser is special handling it:

pitchfork/ext/pitchfork_http/pitchfork_http.rl

Lines 337 to 345 in cd708bc

 /* 

 * "OPTIONS * HTTP/1.1\r\n" is a valid request, but we can't have '*' 

 * in REQUEST_PATH or PATH_INFO or else Rack::Lint will complain 

 */ 

 if (STR_CSTR_EQ(str, "*")) { 

 str = rb_str_new(NULL, 0); 

 rb_hash_aset(hp->env, g_path_info, str); 

 rb_hash_aset(hp->env, g_request_path, str); 

 }

from pitchfork.

Earlopain commented on August 19, 2024

Yeah, I'm looking at this as well right now. A bit unfortunate, Rack 3.0 (and probably 2 as well) still require PATH_INFO to start with /. It's easy enough to change there but then it would only comply with the latest version.

The parser probably needs to become aware of the rack version. Would you mind me creating a PR for this?

from pitchfork.

casperisfine commented on August 19, 2024

Arf, there's also a problem with chunked encoding:

  1) Failure:
HttpBasicTest#test_chunked_encoding [test/integration/test_http_basic.rb:40]:
Expected: "chunked"
  Actual: nil

from pitchfork.

Recommend Projects

Test failure against Rack 3.1 about pitchfork HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/*
	* "OPTIONS * HTTP/1.1\r\n" is a valid request, but we can't have '*'
	* in REQUEST_PATH or PATH_INFO or else Rack::Lint will complain
	*/
	if (STR_CSTR_EQ(str, "*")) {
	str = rb_str_new(NULL, 0);
	rb_hash_aset(hp->env, g_path_info, str);
	rb_hash_aset(hp->env, g_request_path, str);
	}