/usr/share/ruby/time.rb is not `.stable?` - path_test.rb failing about bootsnap HOT 9 CLOSED

I'd submit fix for this, but the question is what is the real intent? What is considered stable?

Given that the comment says: "Built-in ruby lib stuff doesn't change, but things can occasionally be installed into sitedir, which generally lives under libdir.", then there should probably be matched libdir as well as datadir.

Another option could be to match rubylibdir instead. That way, the exception for sitedir could be probably dropped, not sure.

BTW this issue is reproducible on Fedora.

from bootsnap.

Thanks for the report. I'll need to dig into the history a bit to see what this stable thing is about.

from bootsnap.

but the question is what is the real intent? What is considered stable?

Ok, so "stable" here is to describe code that come from either the stdlib or gems, as opposed to your application code.

So anything coming from the ruby installation can be considered stable.

I'd submit fix for this

Please do if the above clarified your question.

from bootsnap.

The code currently assumes that everything, what is under /usr/lib64 is stable, with possible exception to sitedir. On standard distribution, that might include large variety of files, i.e. majority of the distribution. If that was the intention, then this should also include the /usr/share.

But I'm going to assume, that intention was to include just Ruby StdLib.

from bootsnap.

Also, I am not Bootsnap expert, so the question is, if only Ruby files needs to be covered or if also arch specific files (.so libraries) should be included.

from bootsnap.

I'm going assume the former.

from bootsnap.

Yeah .so files should be included.

from bootsnap.

Yeah .so files should be included.

Oh, Ok, going to fix the PR to include them.

from bootsnap.

Should be fixed by 72202aa, let me know if that's not the case.

from bootsnap.