Git Product home page Git Product logo

Comments (1)

trusktr avatar trusktr commented on June 3, 2024

In some ways, because I don't see a good reason for such events to bubble, encapsulation feels interrupted because sl-hide events from some other element are sneaking into my higher element's event handler.

I think it would be better for a user to emit a custom bubbling event when they want to explicitly make that functionality, and here's how they could do it:

// this is code in some custom element far down:
class ElementFarDown extends Element {
  template() {
    return html`
      <sl-select on:sl-hide=${() => this.dispatchEvent(new MySelectHiddenEvent())}>...</sl-select>
    `
  }
}

class MySelectHiddenEvent extends Event {
  constructor() {
    super('my-select-hidden', {bubbles: true})
  }
}

and then in their app, they can expect that unique event, so that the wiring is more explicit and show that they intended for it to happen:

// code in a high-up element:
class HighUpElement extends Element {
  template() {
    return html`
      <div on:my-select-hidden=${() => console.log('some low-down select was hidden')}>
        <sl-dialog 
          on:sl-hide=${() => console.log('dialog hidden (not some other element unexpectedly hidden)')}
        >
          ...
        </sl-dialog>
      </div>
    `
  }

  connectedCallback() {
    super.connectedCallback()
  }
}

Then this way there is a lot less chance of surprises.

from shoelace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.