Comments (9)
There was a lot of discussion about this in the past. We actually had a lot of
discussion in the protocol definition about making it an *unsigned* 64-bit
integer on the wire. I still think that was a pretty awful mistake, but oh
well.
In practice, I don't think people are likely to be bumping counters up by more
than 2 billion at a go, but I won't argue that it's wrong. It can't go in in a
minor version, though, because it'll change the method signature.
Original comment by [email protected]
on 26 Aug 2011 at 6:38
- Changed state: Accepted
from spymemcached.
Thank you. I use one bit-shifted counter to store 3 different values so that's
why I need to increment by a large values.
One option that might make it eligible for minor version release is if you
added different methods for incr/decr by a long and the previous int version
delegated to them.
Original comment by [email protected]
on 26 Aug 2011 at 3:41
from spymemcached.
Yeah, that I'd rather not do. There are already way too many methods in there.
I've been hoping to get rid of the bulk of them for years. :(
Your case makes sense, though. I've not heard of anyone doing that before.
Original comment by [email protected]
on 26 Aug 2011 at 4:50
from spymemcached.
Original comment by [email protected]
on 29 Aug 2011 at 5:33
- Added labels: Milestone-Release2.8
from spymemcached.
I have to disagree with dsallings on this. Just changing it from int to long
will suddenly break a lot of code. I agree that there are too many methods in
there, but shipping a library update that breaks existing binaries is just
wrong, especially when it can be prevented.
As annoying as it might be, perhaps we need to update the interface, the class
and include an abstract to implement this?
Sorry to be late to the discussion.
Original comment by [email protected]
on 7 Sep 2011 at 2:17
from spymemcached.
I was thinking about having it come in as a new version. I don't want to just
keep broadening the surface area. The number of methods has already nearly
tripled from when I tried to start bringing it down. :/
If it is decided to do both, we should at least deprecate some of the stuff we
don't want people using so we *can* get rid of it in the future.
Original comment by [email protected]
on 7 Sep 2011 at 7:24
from spymemcached.
I agree that we should deprecate and remove in the future. I just don't want
people to be afraid to update to newer versions, which is what we may cause if
we randomly take away functions. People don't always get to rebuild from
source. Ops people sometimes need to update something to address a bug,
without cracking open a project.
If this were rarely used functionality, I'd say we can break it and release
note it, but incr is probably super common.
Original comment by [email protected]
on 7 Sep 2011 at 6:19
from spymemcached.
Original comment by [email protected]
on 24 Oct 2011 at 10:13
- Changed state: Fixed
from spymemcached.
Fixed in 2.8 developer preview 3
Original comment by [email protected]
on 24 Oct 2011 at 10:14
from spymemcached.
Related Issues (20)
- State the dependencies in the pom file HOT 5
- Multhreaded implementation with SASL support not working. HOT 1
- Operation class is used in un-threadsafe, unsynchronized manner. HOT 4
- Inside TCPMemcachedNodeImpl, use direct buffers HOT 4
- Stability problems in async I/O HOT 4
- assertion failure during ConsistentHashingTest HOT 1
- Zlib encoding/binary access HOT 3
- getBulk() logs a warning when no keys are in the cache HOT 3
- bug in OperationImpl HOT 6
- get(long timeout, TimeUnit unit) may take longer than given timeout HOT 3
- IllegalArgumentException after Switching from SpyMemcached 2.7 to 2.7.1 HOT 2
- "unl" unlock operation is not implemented on MembaseClient HOT 9
- 2.7.1 jar for download corrupt? HOT 5
- Callback support HOT 11
- Get canceled HOT 5
- CAS operation fails due to client sign-extending the CAS value HOT 1
- warning for "handling node for operation is not set" if any server is down HOT 4
- javadoc warnings from tap and vbucket classes HOT 3
- CASMutator removes expiry on mutated items
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spymemcached.