Comments (8)
Can I take this up and fix this issue?
from jmailtm.
well heyπ@aarahmanqa , thanks for pointing out this issue.
maybe mail.tm has gone through some changes in their api because i remember it used to return an empty array[]
keeping that aside i would love to merge your pull request so you can work on that bug. (I'm just hoping it doesn't break anything π)
from jmailtm.
Thanks Shivam. I would like to ask one more thing. There are many places here that are prone to NullPointerException.
Like, json.get("html").toString();
In case, the json.get("html") returns null, we would get NullPointerException. Rather it would be good if we can get it as null itself.
To overcome such issues, I used to follow this. Shall I implement the same here as well?
from jmailtm.
the mail.tm api promise the value of the key html
in the json so it would never throw NullPointer
because mailtm converts raw text to html format and even if you supply no body to the smtp protocol its going to return an empty array[]
so i don't think there is any need for it.
from jmailtm.
Yeah I agree to your point Shivam. I have mentioned "html" just for reference. It could happen in any field. When a field is null, we need to accept it as null, right? It would be better instead of throwing NullPointerException. I will propose my solution as enhancement and raise PR, we shall discuss it. Please feel free to close it if not needed.
from jmailtm.
I have raised PR for this issue. Request you to kindly go through the same.
#6
from jmailtm.
Fixed in pull request #6 π
from jmailtm.
@shivam1608 , when shall we expect the fix in remote build?
from jmailtm.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jmailtm.