`@shikijs/rehype` - "30 instances have been created" about shiki HOT 6 CLOSED

Thanks, I see it better now. If in unified, the plugin are supported to be used in a factory function, I think that would make sense for us to use the shared singleton instance by default. Made the change in c4f030d.

from shiki.

Same problem here.
Using markdown-it as a plugin for nuxt3.

import mdShiki from "@shikijs/markdown-it";

  const renderer = MarkdownIt({
    linkify: true,
    html: true,
  })
    .use(mdFootnote)
    .use(
      await mdShiki({
        themes: {
          light: "snazzy-light",
          dark: "nord",
        },
      }),
    )

from shiki.

Facing the same issue with @shikijs/rehype

from shiki.

@babakfp I am sorry, where is your related code in your reproduction?

from shiki.

About this warning in general, ideally you should avoid creating new rehype instance in a loop. For everyone who encountered this warning, please review your usage and see if there is a refactor you could make. Also share your usage and fix here, so we could have a better understanding of how people are using it, and potentially improve the docs.

from shiki.

@babakfp I am sorry, where is your related code in your reproduction?

Sorry about that.

I made a proper reproduction here: https://github.com/babakfp/shikijs-shiki-issues-714

Watching this video may be helpful.

It seems like the message only shows up on every second or third restart of the server. When just running pnpm dev, it doesn't show up. If you do (ctrl + s) after that, it still doesn't show up. If you do it again, it shows up.

In my https://github.com/babakfp/babakfp.ir project, it happens after running pnpm dev. Maybe something is wrong with my code that Vite/SvelteKit auto restarts the server, and it triggers the message.

from shiki.