Git Product home page Git Product logo

Comments (4)

sdushantha avatar sdushantha commented on May 16, 2024

Unfortunately sherlock doesn't take any of these into account and it can be misleading for user (for example, he might think that username is taken but it is, in fact, illegal).

That is very true.

A way we could fix that is to use a regex for each of the networks. I am not good with regex but, I guess we can learn on the go 😄

When I think about it, I kinda feel like we should make a seperate file for each social network. Just like youtube-dl. In youtube-dl each site has its own extractor.

https://github.com/rg3/youtube-dl/

from sherlock.

hoadlck avatar hoadlck commented on May 16, 2024

I wonder how well the user name requirements are documented for each site? I found an place here that had the requirements for GitHub's user name. There are quite a few requirements.

I don't think that the regular expressions will be very hard: it is the research to find the exact requirements.

from sherlock.

hoadlck avatar hoadlck commented on May 16, 2024

I added the infrastructure to be able to specify a unique regular expression pattern for each site with pull request #16 .

The regular expression for GitHub itself is correct, but I am not sure about all of the rest.

from sherlock.

sdushantha avatar sdushantha commented on May 16, 2024

Closing this because this is being done now. It is very difficult to come up with a regex for some sites because they do no provide us any information about what they username criteria is. We currently have 16 sites which has a regex check.

from sherlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.