Can local variables of the function under test be modified by the test case simulation? about shellspec HOT 3 CLOSED

---Original--- From: "Alexandre do ***@***.***> Date: Thu, Sep 21, 2023 21:23 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [shellspec/shellspec] Can local variables of the function undertest be modified by the test case simulation? (Issue #305) Hello Msmevol. When call command runs on the same environment than the example block, since it doesn't run in a subshell. This grants hello function access to p1 values defined within the same example/example group block. Furthermore, in general, mock techniques are intended to be used with functions (or classes/objects depending on the context), so I would expect p1 definition to be something like p1="world". You don't even need to define p1 with local as ShellSpec already isolates the examples and example groups one from the other. In bash, when one define a local variable that have the same name as the global variable, it shadows the global variable. Thus the line echo p1 of the hello function refers to the local variable. In my experience, the local values are intended to not pollute the global environment of the script and to protect the variables used inside the function. This way, unless the value of the local variable is defined by the command args, it doesn't make sense to modify those values. If you feel that you must test different values of a local variable, maybe the variable need to be not local or there's an architectural flaw. Best regards. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>