Git Product home page Git Product logo

Comments (7)

jurrejansen avatar jurrejansen commented on July 22, 2024

Hi @DonKoko

Can you check the changes I made to the upload field: https://www.figma.com/file/2XkiKJ4II7Mux6JJL9hYTm/Shelf-App-%7C-Production-Ready?node-id=5344-288576

Could something like this work with the tech ur using? It resolves the success and error messages.

I'm not entirely sure what the limitations are regarding the position of the preview picture. But we could place it

Here

Screenshot 2023-03-24 at 11 01 53

Or here

Screenshot 2023-03-24 at 10 59 27

from shelf.nu.

DonKoko avatar DonKoko commented on July 22, 2024

Okey so option 1 is not really great, because once the user uploads they will not see the upload thing anymore so they wont be able to upload a new once.
The second one is fine but it will add some layout shift which might not be that great. We can animate the layout shift to make it smoother.
Also doing the % is kind of a biatch. So maybe we can just use a lottie?

from shelf.nu.

DonKoko avatar DonKoko commented on July 22, 2024

Just placing here some examples of uploading to supabase storage in remix:
https://makerkit.dev/docs/remix-supabase/uploading-data-to-storage
https://dev.to/aaronksaunders/how-to-upload-to-storage-buckets-and-write-data-with-remix-and-supabase-3l7c

from shelf.nu.

DonKoko avatar DonKoko commented on July 22, 2024

@carlosvirreira @jurrejansen this is deployed and ready for testing. Please test different file format, different file sizes etc. I think its good for now, i cant think of anything we are missing.

from shelf.nu.

jurrejansen avatar jurrejansen commented on July 22, 2024

@DonKoko did a bunch of test uploads and everything seems to work as expected (including errors and stuff).

Only thing I notice is the width of the upload field (also the rest of fields). Looks cleaner if all the rows have the same max width.

Screenshot 2023-04-04 at 10 33 37

from shelf.nu.

DonKoko avatar DonKoko commented on July 22, 2024

@jurrejansen solved and deployed. Can you check it please.

from shelf.nu.

jurrejansen avatar jurrejansen commented on July 22, 2024

@DonKoko seems good

from shelf.nu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.