Comments (4)
Based on our discussion yesterday I have implemented the following sizes for headings:
Display 2xl = H1
Display xl = H2
Display lg = H3
Display md = H4
Display sm = H5
Display xs = H6
This however seems inconsistent with the design of the app.
If I look at the biggest heading on the page, based on basic HTML semantics and structure that should be an H1. However when I look at it it uses display-sm
which above is defined for H5.
At this point I am confused what to do. I will override the default styles we defined, however I am concerned that in the future that will cause a domino effect when updating the UI.
from shelf.nu.
@carlosvirreira I have implemented the primary button color based on the new design you made on friday. What I am missing or I simply dont know how to see are hover/focus states of the buttons.
Also it would be good to know what the transitions are on the hover states.
from shelf.nu.
Hi @DonKoko
Our buttons have 4 states.
- Default
- Hover
- Focused
- Disabled
For the example above:
- Default - background = base/white | border (inside) 1px - gray 300 | (drop shadow) Shadow / XS (blur = 2 / Y = 1) 101828 (5% opacity)
- Hover - background = gray 50| border (inside) 1px - gray 300 | (drop shadow) Shadow / XS (blur = 2 / Y = 1) 101828 (5% opacity)
- Focused - base/white | border (inside) 1px - gray 300 | (drop shadow) Shadow / XS focused 4px - gray 100 (blur = 2 / Y = 1) 101828 (5% opacity) + F2F4F7 - spread 4 (199% opacity)
- Disabled - base/white | border (inside) 1px gray /200 | Shadow/XS
from shelf.nu.
This is done for now.
from shelf.nu.
Related Issues (20)
- [Improvement request]: Optimize thumbnail images used in some indexes and Asset page HOT 2
- [Bug]: Issue with Multiline text
- feat: Request to delete account
- [Bug]: Search Persistent Filters HOT 2
- [Feature request]: Reported Asset Found
- [Feature request]: Send Mail when Team Trial Webhook updates HOT 1
- [Feature request]: Batch Custom Fields
- [Feature request]: Kit Location and Activity
- fix: Tags filter on asset index should be AND instead of OR HOT 1
- [Improvement]: Adding Assets in Bookings performance HOT 3
- Bug: Asset index filters are working with OR rather than AND
- Feature: Add assets to existing booking from asset page
- [Bug]: Typo on dashboard
- Feature: Dashboard "Top custodians" include custodians via bookings HOT 2
- [Bug]: Team Archived Bookings HOT 2
- chore: fix error boundary error
- [Feature request]: Add MYR currency
- [Bug]: Issues rendering individual booking lines on certain condition + overflowing
- Bug: Max client connections reached
- [Bug]: Issues rendering calendar on mobile (live) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shelf.nu.