Comments (4)
Based on our discussion yesterday I have implemented the following sizes for headings:
Display 2xl = H1
Display xl = H2
Display lg = H3
Display md = H4
Display sm = H5
Display xs = H6
This however seems inconsistent with the design of the app.
If I look at the biggest heading on the page, based on basic HTML semantics and structure that should be an H1. However when I look at it it uses display-sm
which above is defined for H5.
At this point I am confused what to do. I will override the default styles we defined, however I am concerned that in the future that will cause a domino effect when updating the UI.
from shelf.nu.
@carlosvirreira I have implemented the primary button color based on the new design you made on friday. What I am missing or I simply dont know how to see are hover/focus states of the buttons.
Also it would be good to know what the transitions are on the hover states.
from shelf.nu.
Hi @DonKoko
Our buttons have 4 states.
- Default
- Hover
- Focused
- Disabled
For the example above:
- Default - background = base/white | border (inside) 1px - gray 300 | (drop shadow) Shadow / XS (blur = 2 / Y = 1) 101828 (5% opacity)
- Hover - background = gray 50| border (inside) 1px - gray 300 | (drop shadow) Shadow / XS (blur = 2 / Y = 1) 101828 (5% opacity)
- Focused - base/white | border (inside) 1px - gray 300 | (drop shadow) Shadow / XS focused 4px - gray 100 (blur = 2 / Y = 1) 101828 (5% opacity) + F2F4F7 - spread 4 (199% opacity)
- Disabled - base/white | border (inside) 1px gray /200 | Shadow/XS
from shelf.nu.
This is done for now.
from shelf.nu.
Related Issues (20)
- [Feature request]: Allow administrators to assign bookings to non-registered members. HOT 2
- [Feature request]: Plus / Team / Enterprise - Allow to download all tags at once
- [Bug]: Expired trial is visible on subscriptions page
- [Feature request]: Allow clear of custom field date
- [Feature request]: On asset edit - show the required field validation errors above the page HOT 12
- [Feature request]: Generate a QR code for a Kit HOT 6
- [Improvement request]: Changes to bookings and integration of kits HOT 1
- [Bug]: User are displayed only with first name and lower capital letters HOT 6
- [Bug]: On PWA the button to save kits is not visible
- [Bug]: Unable to Edit Existing Custom Fields Despite Being Within the Limit
- [Feature request]: use Algolia and their React components for search by facets and text HOT 2
- [Bug]: As a Self-service user the Custodian field appear empty in the initial modal when creating a booking
- [Feature request]: When an asset is ‘checked out’ you do not see to whom or how on the asset page. HOT 1
- [Feature request]: I can see the face of one of my team members on the asset index. But not on the asset page? HOT 1
- [Bug]: OTP token cannot be validated / "prepared statement 's0' does not exist" HOT 3
- [Feature request]: Bookings tab on asset page HOT 4
- [Feature request]: add quantities of items for certain assets (Via Power User) HOT 2
- [Bug]: Possible to create blank NRMs due to button not being disabled / Name field not being required HOT 1
- [Feature request]: Asset index - store searchParams
- [Feature request]: Custom primary Asset ID field HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shelf.nu.