Git Product home page Git Product logo

Comments (4)

DonKoko avatar DonKoko commented on August 24, 2024

Based on our discussion yesterday I have implemented the following sizes for headings:

Display 2xl = H1
Display xl = H2
Display lg = H3
Display md = H4
Display sm = H5
Display xs = H6

This however seems inconsistent with the design of the app.
If I look at the biggest heading on the page, based on basic HTML semantics and structure that should be an H1. However when I look at it it uses display-sm which above is defined for H5.

Image

At this point I am confused what to do. I will override the default styles we defined, however I am concerned that in the future that will cause a domino effect when updating the UI.

from shelf.nu.

DonKoko avatar DonKoko commented on August 24, 2024

@carlosvirreira I have implemented the primary button color based on the new design you made on friday. What I am missing or I simply dont know how to see are hover/focus states of the buttons.
Also it would be good to know what the transitions are on the hover states.

from shelf.nu.

carlosvirreira avatar carlosvirreira commented on August 24, 2024

Hi @DonKoko

Our buttons have 4 states.

  1. Default
  2. Hover
  3. Focused
  4. Disabled

Screenshot 2023-03-13 at 09 57 17

For the example above:

  1. Default - background = base/white | border (inside) 1px - gray 300 | (drop shadow) Shadow / XS (blur = 2 / Y = 1) 101828 (5% opacity)
  2. Hover - background = gray 50| border (inside) 1px - gray 300 | (drop shadow) Shadow / XS (blur = 2 / Y = 1) 101828 (5% opacity)
  3. Focused - base/white | border (inside) 1px - gray 300 | (drop shadow) Shadow / XS focused 4px - gray 100 (blur = 2 / Y = 1) 101828 (5% opacity) + F2F4F7 - spread 4 (199% opacity)
  4. Disabled - base/white | border (inside) 1px gray /200 | Shadow/XS

from shelf.nu.

DonKoko avatar DonKoko commented on August 24, 2024

This is done for now.

from shelf.nu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.