Boolean config settings for enabled area types don't work about silverstripe-blocks HOT 5 CLOSED

Interesting... there wasn't any intention for people to use false, and no reason to use false, but I guess the fact it's a boolean value implies you could if you wanted to. I'll address this when I have more time by checking for false value in getAreasForPageType or you could send a PR :)

from silverstripe-blocks.

I think there's a good reason to allow false - say if none of your templates include a Sidebar, or if you only have one Blocks area in your templates, you'll want to completely exclude most of the options. Also a bit short on time but if I find some spare before you do I'll send a PR :P

from silverstripe-blocks.

Hang on though why declare Sidebar: false when you can just not put Sidebar in your area config to begin with?

from silverstripe-blocks.

Ergh my brain's not working properly - you're right!

from silverstripe-blocks.

Hehe all good man :)

On Fri, Aug 7, 2015 at 8:43 AM, Jono Menz [email protected] wrote:

Closed #30 #30.

—
Reply to this email directly or view it on GitHub
#30 (comment)
.

Shea Dawson
Web Developer
LiveSource

mobile +64 20 4028 5647
skype squatchnz
email [email protected]
*web *www.livesource.co.nz

from silverstripe-blocks.