Git Product home page Git Product logo

Comments (6)

sheadawson avatar sheadawson commented on July 30, 2024

Yeap I agree these are issues and I've been considering addressing them for a while actually. In my implementations I have rarely used the block sets and global blocks, they're important but I do feel that page level blocks should be the priority. It'd be great if we could work on a branch for these changes towards an official tagged release for this module.

  • Block->Area managed on many_many_extraFields (on relations Page, SiteConfig, Blocksets)
  • Block->Weight managed on many_many_extraFields (on relations Page, SiteConfig, Blocksets) and drag/droppable with GridFieldOrderableRows
  • Ability to specify Above or Below on global/blockset blocks many_many_extraFields to determine where they should sit with the page specific blocks.

Thanks for the suggestions. Let me know if you have any other thoughts/ideas :)

from silverstripe-blocks.

micschk avatar micschk commented on July 30, 2024

Well, that'd be something I'd like to take on. I'll try not to break stuff, as I'm not too experienced with Github. Would you add me to the repo as a collaborator or would you prefer I'd write PR's to a branch?

from silverstripe-blocks.

sheadawson avatar sheadawson commented on July 30, 2024

Awesome. I'll add you as a contributor. I've just updated the "dev" branch to where master is. So just push your changes to that branch and we can test/review there then merge into master when we're both happy with how it's working.

Thanks :)

from silverstripe-blocks.

micschk avatar micschk commented on July 30, 2024

About half-way now: https://github.com/sheadawson/silverstripe-blocks/tree/dev

from silverstripe-blocks.

sheadawson avatar sheadawson commented on July 30, 2024

Nice work! Just been going through it all now and have pushed up some more changes. Most notably:

  • Removed global blocks (block sets can be used to achieve the same thing)
  • Added ability to exclude any page types from using blocks
  • Dropped support for multisites module
  • Tidied up block sets
  • Block ExtraCSSClasses is now an optional feature (enabled via yaml config)
  • Use AddNewMulticlass for adding new blocks in gridfield

Notes:

  • You added GridFieldDetailFormCustom class (used in model admin) but it's not in the repo. Do we still need this?
  • Wondering how we would best allow the user to select block area in the same step as creating a block from site tree/block gridfield? At the moment it's a 3 step process to create a block from page edit view, could be two steps?
  • PageListAsString - This is really nice. Would be great to list block sets that the block is applied to too
  • I think I'm happy not to add legacy support for all these changes. Do you think it's worth it?

Keen to hear any of your thoughts on where we're up to now. Thanks for your work :)

from silverstripe-blocks.

sheadawson avatar sheadawson commented on July 30, 2024

Ok I've just completed the most part of the stuff we set out to do and released a 1.0 branch. See the readme for full list of new features. And thanks for your help!

from silverstripe-blocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.