Git Product home page Git Product logo

Comments (3)

balazsbohonyi avatar balazsbohonyi commented on July 30, 2024 2

Forgot to mention where exactly fix this. It's in the getEditForm() method of the BlockAdmin.php class

so change this:

$blockGridField->setConfig(GridFieldConfig_BlockManager::create(true, true, false));

to this:

$blockGridField->setConfig(GridFieldConfig_BlockManager::create(true, true, true));

from silverstripe-blocks.

balazsbohonyi avatar balazsbohonyi commented on July 30, 2024

I stumbled upon this issue in the middle of a project after I created a couple of custom blocks :(

I spent 2 hours figuring out what happens, and found a solution.
There's a configuration class created for managing the blocks in a GridField here: /blocks/code/forms/GridfieldConfig_BlockManager.php

The 3rd parameter of the constructor is $canDelete = true, but when setting the GridField config in the getEditForm() method the constructor for GridfieldConfig_BlockManager is called with false for that argument:

$blockGridField->setConfig(GridFieldConfig_BlockManager::create(true, true, false));

Change it to $blockGridField->setConfig(GridFieldConfig_BlockManager::create(true, true, true)); and it will work.

from silverstripe-blocks.

balazsbohonyi avatar balazsbohonyi commented on July 30, 2024

I also tried to do this by using the Extension API but it's not working since the getEditForm() is missing the following line before the return $form statement:

$this->extend('updateEditForm', $form);

If that line would be there we shouldn't tamper with the core blocks source code - but I'm afraid there's no other way to make this work until it's not fixed.

from silverstripe-blocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.