Git Product home page Git Product logo

Comments (11)

sharkdp avatar sharkdp commented on May 13, 2024

Hm... I also use Fira Code in my terminal (on Linux) and do not have any problems with that symbol.

Edit: works in Alacritty, too

from hexyl.

lzybkr avatar lzybkr commented on May 13, 2024

Weird - it does seem to be the font though - this is what I see in the Font Settings control panel (and this also shows I have what seems to be the latest version of the font):

image

from hexyl.

sharkdp avatar sharkdp commented on May 13, 2024

Does this also appear with other fonts?

from hexyl.

lzybkr avatar lzybkr commented on May 13, 2024

I only tried Consolas and that rendered correctly.

from hexyl.

sharkdp avatar sharkdp commented on May 13, 2024

If there is really a general issue with this character, I'm certainly okay with changing this. However, it seems strange to me to change that character just because your font setup seems to be broken.

from hexyl.

roryokane avatar roryokane commented on May 13, 2024

Here are some more data points for the terminal emulators Terminal and iTerm2 on macOS. In all of the tested fonts, the character is displayed. In some fonts its alignment is wrong, in others it is correct. The choice of terminal emulator does not make a difference to whether the character is correctly aligned.

I draw no conclusion from this data on whether the character should be changed.

Fonts in which the character is misaligned

16pt Consolas

Terminal

Terminal 16pt Consolas

iTerm2

iTerm2 16pt Consolas

16pt Fira Code

Terminal

Terminal 16pt Fira Code

iTerm2

iTerm2 16pt Fira Code

18pt Ubuntu Mono

Terminal

Terminal 18pt Ubuntu Mono

iTerm2

iTerm2 18pt Ubuntu Mono

Fonts in which the character is aligned correctly

16pt DejaVu Sans Mono

Terminal

Terminal 16pt DejaVu Sans Mono

iTerm2

iTerm2 16pt DejaVu Sans Mono

16pt Menlo

Terminal

Terminal 16pt Menlo

iTerm2

iTerm2 16pt Menlo

from hexyl.

sharkdp avatar sharkdp commented on May 13, 2024

@roryokane Thank you!

If somebody wants to suggest a different character (or maybe just remove the additional vertical lines), I'd be ok with changing this.

from hexyl.

dmke avatar dmke commented on May 13, 2024

Maybe a CLI flag to disable ?

Or a --borders={fancy,simple,none} flag, where fancy is the curent default, simple either removes or replaces it with |, and none disables both horizontal and vertical borders (I personally question the usefulness of the bordering, and would alias hexyl='command hexyl --borders=none immediately ;-)).

from hexyl.

sharkdp avatar sharkdp commented on May 13, 2024

What do others think? Should we just remove the borders completely? Could somebody provide a screenshot of how that would look like?

from hexyl.

dmke avatar dmke commented on May 13, 2024

Here's a mockup quickly cobbled together:

image

Note, this only removed horizontal borders and replaced the vertical ones with a space.

from hexyl.

sharkdp avatar sharkdp commented on May 13, 2024

Closed via #54 by @dmke.

from hexyl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.