PHP: Numbers that are a string about mr-data-converter HOT 6 OPEN

Same issue here.

from mr-data-converter.

[Update] Current situation in the Demo:

• Numbers that contain special chars like '.' or '-' are quoted, simple numbers are not.
  Just like @ursbraem, I believe that it's way better to quote everything.
  But anyway...might be OK to close this issue if you like to.

from mr-data-converter.

There is another scenario to consider: postal codes. For example, I'm converting a sheet with a postal code column that contains the value "0800" (a postal code in Australia). The converted JSON property is "postcode":0800, which is invalid. Please provide an option to quote all values, even when the string is all numbers.

from mr-data-converter.

@thdoan In my situation, UPC code starts with zeros some times. I forked a copy and commented out a few lines.
in js/CSVParser.js

  //---------------------------------------
  // UTILS
  //---------------------------------------

  isNumber: function(string) {
//  if( (string == null) || isNaN( new Number(string) ) ) {
      return false;
    },
//   return true;
 // },

You could probably deleted the whole thing but basically it returns false all the time so it never tries to parser into numbers/int

I would add an option to turn this off and on though. But this was a quick and easy way to change the tool to get the same results.

from mr-data-converter.

@victor-t I fixed this long back, along with a few other enhancements in my fork.

from mr-data-converter.

@thdoan I figured but just incase ;) i'll take a look at your fork cause i just recently started using this.

from mr-data-converter.