Hi. Really cool library. I was wondering if it would be possible to support detecting

Looking good. Couple of suggestions. It makes sense to memoize

Universal Logger Support? about rescript-logger HOT 4 CLOSED

shakacode commented on August 11, 2024

Universal Logger Support?

from rescript-logger.

Comments (4)

TomiS commented on August 11, 2024 1

@alexfedoseev Cool. I'll see if I'll find a way (and time) to make it happen.

from rescript-logger.

alex35mil commented on August 11, 2024 1

Looking good. Couple of suggestions.

It makes sense to memoize platform value.
You can do this to get rid of raw:

[@bs.val] external window: 'a = "window";
window->Js.typeof == "undefined"

from rescript-logger.

alex35mil commented on August 11, 2024

Hey, I wouldn't mind having UniversalLogger.re that leverages current loggers but I'm not sure about details of environment detection and it'd be far low in my priorities list in the near future to make it happen. I would happily accept PR though!

from rescript-logger.

TomiS commented on August 11, 2024

Ok, not yet a PR, but I made one kind of working PoC inside my app. It looks like this:

// Let's define a variant because it's pretty
type platform =
  | Browser
  | Node;

// Utilizes 'ugly' raw javascript tester function
// that simply checks if window is available
let getPlatform = () => {
  let windowExists: unit => bool = [%raw
    {|
  function() {
    if (typeof window === 'undefined') { return false; }
    else return true;
  }
|}
  ];
  if (windowExists()) {
    Browser;
  } else {
    Node;
  };
};

// An universal wrapper module
module Log = {
  let error = (loc: string, msg: string) =>
    switch (getPlatform()) {
    | Browser => BrowserLogger.error(loc, msg)
    | Node => NodeLogger.error(loc, msg)
    };

  let info = (loc: string, msg: string) =>
    switch (getPlatform()) {
    | Browser => BrowserLogger.info(loc, msg)
    | Node => NodeLogger.info(loc, msg)
    };

  let warn = (loc: string, msg: string) =>
    switch (getPlatform()) {
    | Browser => BrowserLogger.warn(loc, msg)
    | Node => NodeLogger.warn(loc, msg)
    };
};