[Improvement] Properties are displayed in lower case about freecad_fastenerswb HOT 14 CLOSED

Yes! I will take a look

from freecad_fastenerswb.

I see, why don't you present them using Title Case, and when saving you do it in lowercase... or even better ignore the case when reading from the file so old versions will be ok, and the new versions of the file will be written in title case.

Once again - this is internal to freecad. That's why you can not translate property names.
The only way to fix it currently, Is create a conversion script that read old files, copy old parameters to new parameters and delete old parameters. Also, every place there is a use for the parametes (fastener WB files or any script that uses it) must be converted as well. I wish that there was a possibility to have a separate display name - this way it was possible to change only the display name and even have translations for it.
Perhaps Freecad will eventually support it.

from freecad_fastenerswb.

@leoheck , After some consideration I decided to change Fasteners to Title Case, Since doing it in freecad core will take sometime.
This work meant changing 72 files and add a built in migration script to migrate old Fastener files.
I guess this comprehensive change might cause some things to break, but I'll fix it once I get feedback from the community.
If you have old files with fasteners, please try them (by loading and doing some changes to the fasteners). Let me know if you encounter issues.
Thanks!

from freecad_fastenerswb.

I am checking this right now, this looks good and professional.

Did not have any issues with a couple of files.
I will close this issue, and if I have any I can open it again, or create a new one. Cool?

from freecad_fastenerswb.

the true/false are built in FreeCad properties. they are not controlled by fasteners workbench

from freecad_fastenerswb.

I see, but this list is a display that does not need to be the Python code itself. You can treat them to display to the user. You can also treat them to get from the user. Freecad is getting polished on the dev version and I thought the text on this extension could be improved too.

from freecad_fastenerswb.

Perhaps I was not clear. I can not change it even if I want to. This is an internal FreeCAD featute.
For example: sketch parameters are also lower case:

from freecad_fastenerswb.

Ah, I see. Then if it is like that everywhere, it is good as it is. Now property names could still be improved to match the other properties, right?

from freecad_fastenerswb.

Your example shows the Title case is used when there is more than one word.

from freecad_fastenerswb.

And... Sorry. Although this name is controlled by the workbench, this is also saved when saving the file. If I change everything to upper case, it will no longer be able to read old files...

from freecad_fastenerswb.

I see, why don't you present them using Title Case, and when saving you do it in lowercase... or even better ignore the case when reading from the file so old versions will be ok, and the new versions of the file will be written in title case.

from freecad_fastenerswb.

I think you can a simple regexp to filter out the case when reading from the file.

from freecad_fastenerswb.

Thanks for the clarification @shaise

from freecad_fastenerswb.

Oh, that's beautiful. Nice @shaise. Thanks for considering this suggestion. As soon as I install it I will test my old files to report in case of any problem.

from freecad_fastenerswb.