gcc_ocl failing with errors in testRefine2class about sgpp HOT 17 CLOSED

In GitLab by @valentjn on Jul 4, 2017, 14:26

mentioned in merge request !13

from sgpp.

In GitLab by @DavidPfander-UniStuttgart on Jul 4, 2017, 14:30

Don't see why it should be a machine problem. Vgpu1 and 2 have a standard ubuntu 16.04 installation. Without actually investigating this, from afar this looks like a bug.

from sgpp.

In GitLab by @degelkn on Jul 4, 2017, 16:41

These tests are from my stuff. I will take a look.

Is there something special I need to care about for the OCL build?

from sgpp.

In GitLab by @DavidPfander-UniStuttgart on Jul 4, 2017, 17:05

For OCL you need an OpenCL installation. Let me try whether I can reproduce the error with OpenCL disabled. I'll report back shortly.

from sgpp.

In GitLab by @valentjn on Jul 4, 2017, 17:12

Unrelated: If this needs code fixes, then I think the proper way would be to create a MR (alongside with a matching branch) with that large green button above and push fixes to that branch. That would allow Jenkins to check if the fixes break anything else.

from sgpp.

In GitLab by @DavidPfander-UniStuttgart on Jul 4, 2017, 17:53

I was able to reproduce the problem without OpenCL.

Configuration:
COMPILER='gnu'
ARCH="avx"
USE_OCL=0
OPT=0
SG_PYTHON=0
SG_JAVA=0

from sgpp.

In GitLab by @DavidPfander-UniStuttgart on Jul 4, 2017, 17:54

You need a non-historical computer for the ARCH="avx" switch (2011 and newer is usually fine).

from sgpp.

In GitLab by @valentjn on Jul 5, 2017, 09:19

Thanks @DavidPfander-UniStuttgart. That command line reproduces the bug on my Ubuntu 17.04 laptop, too. More specifically, I did

git clone --depth 1 [email protected]:SGpp/SGpp.git sgpp_issue43
cd sgpp_issue43/
scons -j 4 COMPILER='gnu' ARCH="avx" USE_OCL=0 OPT=0 SG_PYTHON=0 SG_JAVA=0

and ended up with the same test error as in the description above. @degelkn, if it doesn't reproduce on your system, I'd be happy to state the versions of GCC and the like.

from sgpp.

In GitLab by @degelkn on Jul 6, 2017, 18:12

I could reproduce the error and found where the error comes from. It seems to be a problem with saving pointers in vectors.

from sgpp.

In GitLab by @valentjn on Jul 6, 2017, 19:03

Excellent. Let us know when you have a fix, then Jenkins can test it and maybe we can close this very soon 😃

from sgpp.

In GitLab by @degelkn on Jul 7, 2017, 15:24

I found a fix, it only affects MultipleClassPoint.cpp. Only 4 lines needed to be adjusted.

Should I create a MR here for the issue or where I should commit this change to?

from sgpp.

In GitLab by @valentjn on Jul 7, 2017, 15:28

created branch 43-gcc_ocl-failing-with-errors-in-testrefine2class

from sgpp.

In GitLab by @valentjn on Jul 7, 2017, 15:28

mentioned in merge request !20

from sgpp.

In GitLab by @valentjn on Jul 7, 2017, 15:30

As I've written above. I have even pressed that button for you 😉

The MR is linked above (!20) and the branch (43-gcc_ocl-failing-with-errors-in-testrefine2class) is also given above.

from sgpp.

In GitLab by @krsgpp on Sep 21, 2017, 13:08

closed via commit 692ab6c

from sgpp.

In GitLab by @krsgpp on Sep 21, 2017, 13:08

closed via merge request !20

from sgpp.

In GitLab by @krsgpp on Sep 22, 2017, 17:53

mentioned in commit 692ab6c

from sgpp.