Git Product home page Git Product logo

Comments (7)

veox avatar veox commented on August 25, 2024

This could be a useful thing to do as far as efficiency goes, but most probably it's just folk's OpenCL compilers misconfigured (because they are shipped that way), or those optimised kernels built with an improved procedure. Or the kernels using constants/attributes sub-optimally.

This is an option to consider; however, I think we shouldn't introduce another level of complexity if unneded.

P.S. The defines are passed as CompilerOptions in ocl.c, and I don't see why hard-coding them makes a difference.

from sgminer.

tixi avatar tixi commented on August 25, 2024

hard-coding them can help to change the code. for instance operator x%y when y is equal to 8192 can be changed to x&8191 and a lot of transformations like that can be performed. (not sure that one is not captured by the compiler directly)
But i fully agree with you that we shouldn't introduce another level of complexity if it provides slightly the same perf at the end.

from sgminer.

veox avatar veox commented on August 25, 2024

I've removed the version from kernel file names, which greatly simplifies kernel change inspection using git diff. As a side effect (along with moving to a separate dir), we don't have to hard-code all available kernel names into the code. Just one "safe default" is enough. This is still done, but is redundant.

With some small modifications, we can allow putting hard-coded .cl files into dir kernel, and just using them by specifying the kernel name in config or on command-line. What needs to be implemented is scanning the dir for what's available and loading it if it's requested by the user.

Sorry if this is hard to parse, I'm a bit busy with a pull request now.

from sgminer.

tixi avatar tixi commented on August 25, 2024

I will not touch it now, i would like to know first if it can improve performance. I try some optimization manually.
If someone has experience on that and can provide feedback, they are welcome.

from sgminer.

veox avatar veox commented on August 25, 2024

With some small modifications, we can allow putting hard-coded .cl files into dir kernel, and just using them by specifying the kernel name in config or on command-line. What needs to be implemented is scanning the dir for what's available and loading it if it's requested by the user.

Working on this in branch kernel-name ATM.

from sgminer.

veox avatar veox commented on August 25, 2024

Comparison: veox/sgminer@f2934d8...ea9c54a

from sgminer.

archenroot avatar archenroot commented on August 25, 2024

superior feature!

from sgminer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.