Git Product home page Git Product logo

Comments (5)

LaurentGomila avatar LaurentGomila commented on May 30, 2024

That's the overload of sfMouse_setPosition that takes a RenderWindow. It is part of sfMouse, not sfRenderWindow.

from csfml.

jeannekamikaze avatar jeannekamikaze commented on May 30, 2024

The thing though is that the RenderWindow overloads are in RenderWindow.h, while the Window overloads are in Mouse.h. I would place the Window overloads in Window.h to make it look consistent.

Edit: and once you do that the parameter order switching becomes natural.

from csfml.

LaurentGomila avatar LaurentGomila commented on May 30, 2024

It belongs to sfMouse, so it has to be in Mouse.h.

The overload in RenderWindow.h is a hack, because C doesn't support polymorphism and sfRenderWindow doesn't belong to the module where the function is supposed to be defined. In the C++ version there's just one function, which is Mouse::setPosition(Vector2i, Window&) so there's no problem at all.

Things should be seen as "there's a function in sfMouse that takes a window", and the sfRenderWindow overload is just a kind of hidden extension that makes this function work for the sfRenderWindow type too.

from csfml.

jeannekamikaze avatar jeannekamikaze commented on May 30, 2024

Ok, in that case I'll mimic the C++ API instead of the C one. I'm trying to make the bindings as close as possible to the original code.

from csfml.

LaurentGomila avatar LaurentGomila commented on May 30, 2024

One should always mimic the C++ API, the C API has to use many ugly hacks because of its lack of object-oriented features.

from csfml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.