Merchant hostility applying to random entities? about sihywtcamd HOT 5 CLOSED

Hello, thanks for the report!
Impossible for me to reproduce the issue... May I know which mobs exactly attack villagers? This is not really expected to happen because the goal added to attack merchant entities (maybe also your guild master if he is a special merchant entity) is added only to specific vanilla mobs. Unless you add a new type of skeletons that extends vanilla ones (which is intended that way), you shouldn't encounter this kind of issue.

from sihywtcamd.

Yeah, like I said, I looked at your code, I have no idea. According to reports it happens for all entities, but I've also received a report specifically about the songbird (which doesn't extend any mixined entity).

from sihywtcamd.

It could be that your injects are applying to the parent class due to a lack of full method qualification, or that the method is not overridden in the targeted class, so it applies to the parent? You could also try adding instanceof checks to the mixins. I don't have a reproduction of the issue considering it's not my report, but you can ask @AshrielV

from sihywtcamd.

The method is overriden by the classes I inject, because I couldn't inject otherwise. And even though it would apply to parent class (which is unlikely the case), the parent classes are HostileEntity or RaidEntity which is not related to animals. I've also checked your code and did not find anything that could cause the issue with my mod.
If @AshrielV can tell me more about the issue, I'd be glad to help fix it =)

from sihywtcamd.

Feel free to reopen if relevant

from sihywtcamd.