Comments (7)
Yeah, that's true. It may mess up the whole usage logic. It's surely a complicated problem.
Anyway, what I got here has already satisfied my need. Thanks a lot for your effort on this matter.
from logseq-plugin-luckysheet.
Glad you like the plugin, I really put some efforts on it.
Regarding the file name, the reason I didn't use "UI name" as file name is a technical one, "UI name" can have arbitrary characters but file name can't. It is highly probable that users use a name that has characters that are not accepted as a file name character. So what I did was to use a hash of the "UI name" instead, to avoid possible "bad" names which affect file saving. This however, makes identifying files difficult for a human. 😅
I need time to think about this. Maybe I can write "UI name" into the file too, in this way, you can open the file with a text editor to identify it.
from logseq-plugin-luckysheet.
I need time to think about this. Maybe I can write "UI name" into the file too, in this way, you can open the file with a text editor to identify it.
I implemented it, you can open the sheets with the new version of the plugin and the ui name will be written into the file upon saving.
from logseq-plugin-luckysheet.
Cool, I've tried it out. It works like a charm.
BTW, is it feasible to just filter out the unsafe characters and automatically leave the rest as the name (for both UI and the file)? Maybe you can append numbers or something to it when the duplication occurs.
I hope I am not asking too much.
from logseq-plugin-luckysheet.
Filtering unsafe characters is not easy task. Whether a character is valid or not depends on the OS you're working on. A character that is valid for macOS might be invalid for Windows, it would be buggy when you port files across operating systems.
I believe even Logseq itself had many bugs related to incorrect file name handlings in the past, there is too many corner cases (think about all the languages that exist in the world).
from logseq-plugin-luckysheet.
I believe even Logseq itself had many bugs related to incorrect file name handlings in the past, there is too many corner cases (think about all the languages that exist in the world).
Bingo! How about we just take the filename already processed by logseq (which is the page's name) as file name of sheets. And we can append numbers to it when adding multiple sheets in one single page.
At the same time, it does not affect the user's ability to modify the UI name.
from logseq-plugin-luckysheet.
from logseq-plugin-luckysheet.
Related Issues (18)
- Data loss HOT 7
- Feature Request: Persist to/Read from CSV/TSV HOT 15
- render以后不能像demo gif显示那样有个外框,还是markdown的表格 HOT 2
- Make it easier to find and open luckysheet files HOT 2
- Feature request: support for org-mode HOT 2
- Frame around table HOT 2
- Feature-request: import-export from excel (= add luckyexcel lib) HOT 3
- 建议导出表格为hiccup HOT 1
- LuckySheet停止维护了,考虑支持Univer不 HOT 2
- 保存的表格信息需要如何直接打开呢 HOT 2
- Super cool idea! But it doesn't sync to other machines. HOT 8
- 安装插件后,命令菜单里没有 luckysheet,为什么? HOT 5
- The sheet cannot be displayed HOT 8
- <br /> doesn't show properly in heading row after MD generation HOT 11
- `数据读取错误!` - Data loading error caused by wrong substring index HOT 1
- 分栏下全屏可以只是当前分栏全屏么? HOT 5
- 手动添加数据的话只能修改前30条数据。 HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logseq-plugin-luckysheet.