MiniBrowser method is_in_browser_rect returns true iff position is in toolbar about servo HOT 2 OPEN

In the prior discussion, Munish wrote:

based on your suggestion. we can change it to something like this and by fetching the window_size in the beginning of the function and using it in is_in_browser_rect

    fn is_in_browser_rect(
        &self,
        position: Point2D<f32, DeviceIndependentPixel>,
        window_size: LogicalSize<f32>,
    ) -> bool {
        position.y < self.toolbar_height.get()
            && position.x >= 0.0
            && position.x <= window_size.width
    }

Is my understanding correct or you are suggesting something else. even with the above change I am not able to get the functionality @Nopey

Let's not add checks for the position's X coordinate, as I'd expect events that occur entirely outside the browser window are already correctly handled (hopefully, by not even being sent to our browser's event loop)

Switching the current code's position.y < ... to position.y >= ... should be sufficient.

from servo.

i withdraw my conclusion. I think checking the y-coordinate should be enough.

from servo.