Comments (1)
The duration and time_update are seconds in doubles because the HTMLMediaElement spec has the time values it exposes as floats. So we're matching the target API's spec here.
If we wanted to export duration and time_update as some kind of TimeStamp, we'd be converting to a TimeStamp in gecko-media, and then converting back to a floating point value when Servo exposed them to JavaScript content.
We should certainly not use floats for time values everywhere, as we're liable to lose precision if we do; we've been burned by that in the past when we were a little greener.
Note that the TimeStamps on frames represent a wall-clock absolute time point, whereas the duration represents a range of time, and the time_update time represents an offset from 0. So they're not semantically all the same concept of time anyway. So rather than unifying into a single concept of TimeStamp, it would make more sense to create TimeDuration and TimeOffset structs for the duration and time_update values rather than making them all TimeStamps.
from gecko-media.
Related Issues (19)
- Fix build dependencies
- Move sample player to separate crate
- PlayerEventSink::update_current_images is unsound HOT 2
- Straighten our safety story with regard to PlayerEventSink HOT 1
- Do not panic across FFI boundaries
- Rename undefs.h
- Intermittent "error: Connection to server timed out" on Servo CI HOT 3
- Test player does not render any frame on OSX HOT 1
- Split 'top' in multiple modules HOT 1
- Make sure GeckoMedia::shutdown doesn't have to start the media stack HOT 1
- Failure on shutting down an internal pthread mutex
- Bindgen can't find stddef.h HOT 10
- Figure out a way to keep gecko/glue/ code in sync with mozillla-central HOT 2
- Move SourceBufferResource.h and TrackBuffersManager.cpp out of glue HOT 2
- GeckoMediaMetadata incomplete implementation
- Segfault running the example player with an mp4 on OSX HOT 2
- Move GeckoMedia* files out of gecko/glue
- Make a new import from Gecko sources
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gecko-media.