make check is failing with "Illegal instruction" about euclid HOT 8 CLOSED

I'm not too familiar with this stuff, but after further research I think that the ptest instruction in is_zero is an instruction for SSE4.1. I'm on a netbook with an AMD C-60 processor, which does not support this.

from euclid.

@bjz: you wrote the assembly, right?

from euclid.

Ran into this on a Core2 Duo (SSSE3 only).

from euclid.

I think it might be safe to close this since this hasn't been reported in a while.

from euclid.

A redditor pointed out (probably @Jurily) that this is still an issue, the code contains a PTEST SSE4 instruction here, but the function on older x86_64 platforms without SSE4 causes an "Illegal instruction" error.

from euclid.

@pmarcelll Can you link to the comment in question?

from euclid.

@frewsxcv Sure, you can see the whole conversation here.

from euclid.

I did a bit of research and I found rust-lang/rust#29717. target_feature is still unstable, but locally it works (I changed #[cfg(target_arch = "x86_64")] to #[cfg(target_feature = "sse4.1")]).
The other option is rewriting the assembly, but I can't really help with that.

from euclid.