__FILE__ about plog HOT 8 CLOSED

Hi!

Actually I tried to use it in the past and got the following results:

• __FILE__ cases full file paths to be present in a binary (that is not desirable)
• In most cases a function name gives more meaningful information than a file name

So I decided to drop __FILE__ in favor of __FUNC__.

If you have any thoughts about this please share.

from plog.

Well, my needs are rather specific... i write a Python module based on some C++ library. I use plog for the C++ part, and i need to get the logs back to the standard Python logging system (so that the end user also has to care about Python).

Somewhere in the cooking i have to build a Python LogRecord object (https://docs.python.org/2/library/logging.html#logrecord-objects). This kind of object typically references the source filename.

("FILE cases full file paths to be present in a binary (that is not desirable)" -> definitely agree, thats why #line can be useful: https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html#Line-Control)

from plog.

#line could help but it requires you to manually specify file names.

What if you just return an empty file name?

from plog.

well, then i don't have the C source filename in Python logs :) Right now i push FILE into Record void* 'object' field, but that doesnt feel "clean".

from plog.

Hey, take a look at the capture-file branch. Will that work for you?

from plog.

Sure, thanks !

(I do think that to provide FILE it's not possible to only work by inheritance, as a custom LogRecord class is not really possible for the user)

from plog.

@stephane-martin How is it going?

from plog.

Merged to master.

from plog.