Git Product home page Git Product logo

Comments (11)

lawliet89 avatar lawliet89 commented on May 3, 2024 1

My use case, at the moment, is trying to implement CORS (before middleware support). I would like to have Options and Get (for example) to be handled by the same function so that I can handle the pre-flight and the actual requests without repeating some code.

from rocket.

echochamber avatar echochamber commented on May 3, 2024 1

It sounds like valid use cases. I agree it can be used to conflate ideas and easily abused. I think best some sort best practices or warning in the docs would helpful at addressing that, at least partially (since the most likely candidates to abuse the feature are newer users, the people who likely to be reading the docs).

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024 1

Closing this as it seems unnecessary. Will revisit if requests call for it.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

Additionally, allow the same argument to be used as both the query and form parameters if GET and POST are both present.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

A workaround can be to simply place multiple attributes on the function:

#[get("/?<form>")]
#[post("/", form = "<form>")]
fn my_form() {

}

This won't work at the moment, of course, because the generated items will have the same name.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

I'd like some feedback from others to determine if this feature is indeed worthwhile. I haven't had a need for it, and it seems to only conflate code and ideas. But if someone has a good use-case, I'm all ears.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

Pushing this to a decision by 0.4.

from rocket.

kylone avatar kylone commented on May 3, 2024

I haven't had much use for this default behavior in Asp.Net MVC. I typically want it to be obvious where a request will be routed. I feel that Get/Post on the same handler function is more hassle than it's worth.

from rocket.

mehcode avatar mehcode commented on May 3, 2024

Routing both GET and POST to the same handler is very useful in a traditional web app that has a postback form.

An example in Flask (Python):

@app.route('/submit', methods=('GET', 'POST'))
def submit():
    form = MyForm()
    if form.validate_on_submit():
        return redirect('/success')
    return render_template('submit.html', form=form)

from rocket.

kylone avatar kylone commented on May 3, 2024

Those sound like valid use cases. Is there anyone that thinks this is a bad idea?

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

Pushing into the future.

from rocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.