Typescript CreationAttributes are always being marked as optional with strictNullChecks disabled about website HOT 5 OPEN

We're migrating to a new way to define models to reduce the TypeScript boilerplate, this includes a new mechanism that determines whether the attribute is optional when creating a new instance.

It considers all nullable properties as being optional, because not specifying them will default to null

It does that by checking whether null can be assigned to the type (null extends T).
I suppose that because when strictNullChecks is false every type will accept null, then every attribute will be considered optional

from website.

It's done inside Model so InferCreationAttributes wouldn't impact that

strictNullChecks is not required but these errors will only be caught by typescript if it's on. I'll add a note in the documentation about that

from website.

I'm moving this issue to our new documentation website repository to keep better track of it

from website.

Update:
It appears to be calculating the required parameters correctly when strictNullChecks: true is configured in compilerOptions in tsconfig.json

Additionally, the parameters are being correctly calculated in [email protected] without strictNullChecks: true

from website.

Right, I tried it with InferCreationAttributes and ran into the same problem. Will strictNullChecks: true be required in the future?

For projects with strictNullChecks disabled it could require some significant refactoring to enable it. Which they should do anyways to be honest.

If strictNullChecks will be required, It'd be a good idea to leave a note about that in the documentation if it's not already

from website.