Comments (2)
Senryoku
commented on June 11, 2024
Implemented the proposed solution here: 5a0908b
Players are randomly inserted in the userOrder array instead of pushed at the end.
from draftmancer.
wrmacrae
commented on June 11, 2024
Nice, looks like it should work to me. I recall a number of tests that depended on the owner being in the first seat, and saw that you got one and I think I've fixed a handful others. I'll pull this and try to be sure that the change didn't add new test flakes, but I think the issue is solved!
from draftmancer.
Related Issues (20)
- Picks missing from Draft Logs after a disconnect
- Unlock draft logs automatically after a time delay HOT 1
- Cube setting to disable Duplicate Protection
- Minesweeper settings HOT 1
- Allow for a cubelist with duplicate protection, but still using the set numbers of cards. HOT 1
- Handle parenthesis in cards name when importing card lists HOT 1
- Import MTGO Logs HOT 1
- Make predeterminedLayouts follow layoutWithReplacement setting HOT 1
- Play Boosters
- suggestion: increase packs per player limit to 45 HOT 2
- add secret lair? HOT 7
- Card Pool desync when a pick is forced while the user is dragging a card HOT 1
- Support overriding settings for each pack
- suggestion: add random seed HOT 2
- CardPool desync: Disappearing cards HOT 3
- Unsanitized quotation marks in .dek files break MTGO import HOT 1
- On Draft Effect: AddToDraftPool HOT 3
- "Search" not working for sideboard HOT 1
- Add Authenticated API
- Additional custom card fields HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from draftmancer.