Node Properties Display Within Side Window Of NodeEditorWindow about node_editor_framework HOT 9 CLOSED

I'd like this too. One of the main reasons I think this makes sense is because as the list of different node types increase, the contextual menu will become more and more complicated to navigate.

Allowing to override the right GUI part of the NodeEditor would allow to have something like a drag-and-drop of nodes and should be the window where each node properties are displayed when selected (instead of the Inspector window).

from node_editor_framework.

I managed to implement this feature with a bug concerning IMGUI elements on my fork repo:
https://github.com/ScriptGeek/Node_Editor

Bug: Throws an exception when clicking on the node that implements this feature:
ArgumentException: Getting control 8's position in a group with only 8 controls when doing mouseDown

Somehow the number of GUI elements changes between the Layout and Repaint events. It was tested using this code as the override method:

public override void DrawNodePropertyEditor()
{
name = GUILayout.TextField(name);
}

How to resolve this problem?

from node_editor_framework.

Try:

if (Event.current.type != EventType.Repaint)
    return;

from node_editor_framework.

I found a solution to the issue...

The event that was causing the issue was EventType.Ignore, so avoiding the call to the DrawNodePropertyEditor method when this event type is the current event results in the exception no longer being thrown.

from node_editor_framework.

👍

from node_editor_framework.

Very nice, I will take a look on adding this to the default nodes.
Maybe there's even a way to avoid duplicate code for NodeGUI and DrawNodePropertyEditor...

from node_editor_framework.

I had in my mind that NodeGUI and DrawNodePropertyEditor were for separate purposes. NodeGUI being better suited for displaying flow control info so that a quick glance at the node graph conveniently indicates key info about the relationships between nodes; for example, displaying the current node state in a state machine. DrawNodePropertyEditor being better able to display the node properties in much more detail; for example, displaying an overabundance of details that would not fit inside the node's graphical area. Using both methods allows for the leveraging of each of their advantages, the best of both worlds.

from node_editor_framework.

You're right, but we don't want to forc this, or? If we still want, we can put the same properties in the node body. But anyway, does work good this way, the node creator has much more flexibility now:)

from node_editor_framework.

Yes, the new method is totally optional and properties can still go anywhere, it's all up to the user of the framework. I'm excited to make some more nodes! :)

from node_editor_framework.