Memory leak when opening a canvas about node_editor_framework HOT 11 CLOSED

Thanks, just took a look and indeed, only when dragging around (or, as is my assumption, when calling OnGUI), I have some severe memory leaks of up to 50MB/second... I have to take a look, thanks very much for reporting this!

from node_editor_framework.

I'm trying to find the culprit and it seems to be related to DrawConnections().

from node_editor_framework.

Just a funny story to justify this finding: I noticed this when I was demoing my thesis to my supervisor (I use this project as a manager for specifying some rules to the creation/generation of obstacles in my platformer game) and after 5 minutes Windows crashed, straight to the log-in screen. :-)

from node_editor_framework.

Yes, you're right, seems to be it;) You're pretty fast, was about to download a leak tracker lol...
Anyway, then I'm assuming it's the drawing formula I'm using or how the textures are handled...

from node_editor_framework.

It is my drawing formula. Adding

UnityEditor.Handles.DrawBezier (startPos, endPos, startTan, endTan, col, tex, width);
return;

in the RTEditorGUI.DrawBezier function, before my implementation, fixes it. I'll examine this more closely and report asap:)

Likely problem:
Creating new Material every line segment drawing (wtf am I stupid)

from node_editor_framework.

Found it!

// NodeEditorGUI.cs:125
Material mat = new Material (Shader.Find ("Unlit/Transparent"));
mat.SetTexture ("_MainTex", tex);
mat.SetPass (0);

from node_editor_framework.

It is, problem fixed, thank you:)

Wow, really?! I hope that didn't ruin your thesis :( That would be absolutely desastrous:(

from node_editor_framework.

Don't understand though why the GC didn't clean up... Maybe to much garbage too fast.... lol

from node_editor_framework.

I was just showing the progress I made since the last meeting we had. It was cool to see Windows spasming and flashing my screen like crazy before exiting my user session. :D

Yeah, probably for being called so many times in a frame.
Are you fixing it, or want me to make a PR?

from node_editor_framework.

Already fixed, I was onto finishing the update anyway:)

from node_editor_framework.

Thanks for looking into this so quickly. ;-)
If you had taken more 15 min to answer, I would had fixed it myself. :P

from node_editor_framework.