h256 native Implementation differs from MessageDigest about semux-core HOT 8 CLOSED

I think this is potentially user error

which hash256 algorithm are you using? you should be using
HASH_ALGORITHM = "BLAKE2B-256";

from semux-core.

in your code you aren't signing the transaction...
you need to sign it before verifying :D

I was able to successfully validate this with both Native and non native implementations. So it looks like if you sign the tx, it validates.

from semux-core.

Please try running

  byte[] msg = Bytes.random(100);
     byte[] hash = Hash.h256(msg);
     byte[] nativeHash = Native.h256(msg);
     System.out.println(Arrays.equals(hash,nativeHash));

and let me know what it prints

from semux-core.

Is this mobile/android? Yea, you might want to call Native.disable() when your program starts up.

It's weird that the native call executes without error... I'm not sure if JNI calls work on android, or if we need to compile for that platform, but using Native.disable() should help you.

from semux-core.

I disabled native completely.
I am using Blake2b-256 .. but i will check that.

I sign the tx... Without signing the error message is: not a correct hex string
So its simply signing wrong...

I will check fir blake- iirc it is set to default like in semux.

Pending mgr would accept a signed msg from own wallet- uses the same Algorithm for sig and validate...

from semux-core.

I believe we have compatibility tests between the native and Java BLAKE2b implementation. @phash please update this ticket if get more findings.

from semux-core.

Was running the following unit test, and get consistent behavior with/out native impl.

    @Test
    public void testCompatibility() {
        String raw = "0x00031409c5f2794d69717d538bfcc150644f7685945cfa00000002540be40000000000004c4b40000000000000000100000165c4f4f54700";
        Transaction tx = Transaction.fromEncoded(Hex.decode0x(raw));
        System.out.println(tx.validate(Network.MAINNET));
        Native.disable();
        System.out.println(tx.validate(Network.MAINNET));
    }

from semux-core.

Imho, this seems to be my fault... damn... Strings... it was blake2s instead of blake2b...

from semux-core.