Git Product home page Git Product logo

Comments (14)

maks-oleksyuk avatar maks-oleksyuk commented on August 22, 2024 1

Yeah, that site looks really nice. How much change is required in the actual chapters?

For each article, you need to add information about the template to the beginning of the page, I have already added this data in the pull request. Maybe only some small details are missing (links, typos, etc.).

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

TOC have weird spacing e.g. https://selwynpolit.github.io/d9book/book/forms.html

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

Also width is weird on https://selwynpolit.github.io/d9book/book/forms.html

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

h2 and h3 sizes seem too similar. Maybe there could be some visual cue? There is a horizontal line but it just seems like they run into each other... e.g. https://selwynpolit.github.io/d9book/book/forms.html

from d9book.

alesrebec avatar alesrebec commented on August 22, 2024

I would increase all fonts to 150%.

Sceenshot how it looks now:
Screenshot from 2023-03-01 12-05-36

With 150% font thoughout the whole site:
Screenshot from 2023-03-01 12-05-49

Screenshot from 2023-03-01 12-05-58

I would also consider width in div.shell which is now set to 670px and really looks too narrow on any bigger screen.
Just too bad not using more width for the text an code.

Quick test (screenshot) with increased width of div.shell:
Screenshot from 2023-03-01 12-11-17

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

Thanks for this @alesrebec I will give these as try ASAP

from d9book.

maks-oleksyuk avatar maks-oleksyuk commented on August 22, 2024

Hello
looking at the current theme, you can notice several unpleasant moments, such as block width limitations and mismatching the block width with the text. This reduces the attractiveness of the site for me.

Proposed resolution:
Perhaps you should consider the just-the-docs theme for the site design.
I noticed that this theme was once used in the settings.
This theme has some pretty great customization and ui components.

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

@maks-oleksyuk Thanks for the thoughts. I also hate how unattractive and unprofessional the look of the site is. I did fiddle with just-the-docs theme but I think I had some problems with it. It was a while ago. I really did like many aspects of it.

Unfortunately I am really weak with front end stuff so I need some help. If you are open to a zoom call and taking a look with me, that would be awesome.

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

@alesrebec I implemented some of the changes you suggested (to the best of my knowledge.) Let me know what you think and thanks again.

from d9book.

maks-oleksyuk avatar maks-oleksyuk commented on August 22, 2024

@selwynpolit thanks for the answer

I made a quick setup to use the just-the-docs theme to demonstrate a possible look of the site.

image
Here's what the desktop version looks like

image
This theme also looks good on mobile devices.

Don't be surprised by the dark theme, I've specified it in the settings.

Also, this theme has many other settings for colors, search, breadcrumbs, and others that need to be customized.
But changing to this theme would require reworking all the .md files to add the necessary information for the theme.

I am also not very strong in this area, but I will be happy to help in any way I can if possible.

from d9book.

alesrebec avatar alesrebec commented on August 22, 2024

It looks much better now already.
Though I agree having Just the Docs and leveraging the side menu would be perfect.

from d9book.

maks-oleksyuk avatar maks-oleksyuk commented on August 22, 2024

It's great to know that you support these changes.

I have partially worked on redesigning the site with a new theme. I'm still looking for better solutions or improvements, so any criticism or comments will be helpful.

I have created a copy of the site - https://maks-oleksyuk.github.io/d9book/bq

Here is a small summary of the changes:

  • the main theme has been changed (the necessary settings have been added to the _config.yml file)
  • static content of the file is replaced by dynamic content
  • updated code blocks (removed <?php, some places are optimized for coding standards, added type annotation for PHP 8)
  • minor changes in the text
  • added some footnotes (warning, see also)
  • copyright is placed in the footer of the site
  • added 404 page
  • added links to the author's repository and Twitter)
  • added buttons with links to the top and to editing

Here are some photos for comparison (scale 75% to 50%)
image
image
image

I also have a few questions/comments

Thank you

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

Yeah, that site looks really nice. How much change is required in the actual chapters?

from d9book.

selwynpolit avatar selwynpolit commented on August 22, 2024

and that side menu is great.

from d9book.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.