Git Product home page Git Product logo

Comments (4)

ianstormtaylor avatar ianstormtaylor commented on June 19, 2024 1

@seiyria awesome! I dig a little digging, and it looks like the SVG transformer technically support ligatures, but that something in the TTF transformation doesn't? I'm not exactly sure, but I opened an issue upstream: nfroidure/svgicons2svgfont#114

from gameicons-font.

seiyria avatar seiyria commented on June 19, 2024

I'm personally not sold on this approach as I don't really understand the benefits of it, but more-over, I don't know how or if the tooling I use supports it. All this really is, is a convenient wrapper for some processes I needed 5 years ago (wow, it's been 5 years!). I'd wonder:

  • how this would work with angular bindings (does <i class="gameicons">{{ name}}</i> work?)
  • what changes need to be made for this to work?
  • are they any packages that can be dropped into the build process to do this?
  • can a separate output for this be created so both options are available?
  • what are the drawbacks and benefits for both approaches?

thanks! looking forward to at least some information but hopefully a PR down the line!

from gameicons-font.

ianstormtaylor avatar ianstormtaylor commented on June 19, 2024

Fair enough, if you haven't touched it in 5 years I doubt it makes sense then. FWIW though, the ligatures approach is a better approach in almost all cases since it means the font can easily be used in places other than CSS.

how this would work with angular bindings (does {{ name}} work?)

Yup, that would work.

what changes need to be made for this to work?
are they any packages that can be dropped into the build process to do this?

I'm not sure how ligatures in fonts are described, so I don't know.

can a separate output for this be created so both options are available?

Yup! Both approaches can exist in the same font.

what are the drawbacks and benefits for both approaches?

The current approach only works for CSS. If you wanted to use the font in mobile apps, printed materials, digital images, etc. then you have to go through a really tedious process to use the glyphs. The only real drawback to the ligatures approach was compatibility, but all modern browsers and operating systems support them these days.

from gameicons-font.

seiyria avatar seiyria commented on June 19, 2024

I see. For what it's worth, I do still regularly use this project, but all I do is wrap game-icons, so unless there's a convenient svg to ligature (or whatever needs to be done), I don't see this being something that gets added.

Which, to be fair, I really only do use the CSS approach.

So, I would accept a PR if you can find a way to add this, but I don't think it's something I need enough to add on my own. I'll leave this open either way since it does seem like a good idea.

from gameicons-font.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.