Git Product home page Git Product logo

Comments (5)

rjenkins avatar rjenkins commented on May 14, 2024 4

I prefer func (*Conn) Produce(req *ProduceRequest) (res *ProduceResponse, err error), also fwiw this is similar to existing Producer APIs for example https://kafka.apache.org/10/javadoc/org/apache/kafka/clients/producer/KafkaProducer.html#send-org.apache.kafka.clients.producer.ProducerRecord-

from kafka-go.

rjenkins avatar rjenkins commented on May 14, 2024 2

@silence44 I think we could get this in pretty quick, let me see if we can get a PR up for next week.

from kafka-go.

silence44 avatar silence44 commented on May 14, 2024

Is this feature in progress right now?
I want to switch from sarama to segmetio but this missing feature stops me. Is there another way to get write offset in current library version?

from kafka-go.

scarbo87 avatar scarbo87 commented on May 14, 2024

I could take on this task.
If I understand correctly, all the necessary data is written in the method produceResponsePartitionV2.readFrom. Is it so?
Do you want to make a new method

func (*Conn) Produce(req *ProduceRequest) (res *ProduceResponse, err error)

analogue of the

func (c *Conn) WriteCompressedMessages(codec CompressionCodec, msgs ...Message) (int, error)

?

In the current code, it is faster to make this variant

func (c *Conn) WriteCompressedMessagesAt(codec CompressionCodec, msgs ...Message) (nbytes int, partition int32, offset int64, timestamp int64, err error)

from kafka-go.

rjenkins avatar rjenkins commented on May 14, 2024

@scarbo87 after some discussions with @achille-roussel we decided to introduce a new client rather modify the existing ones. I'm out until Jan 4th, so current ETA on this for me is week of Jan 7th. If you need it sooner and want to take a pass at it, PRs are always welcome 👍

from kafka-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.