Comments (8)
Can't we just have a single package like the react-ui-library? It seems to me that this monorepo thing is super over complicating things and I don't really see the benefits.
from evergreen.
With webpack's tree shaking, bundle size shouldn't really be an issue with having a single package.
from evergreen.
Yeah this is somewhat annoying with a mono-repo. It seems reasonable enough to do this.
We can consider something like evergreen-core
or whatever with a opinionated subset of components if bundle size becomes an issue.
from evergreen.
I am wondering what other mono-repo's do here, or if there is any best practices.
from evergreen.
I am still onboard on the mono-repo thing. A single package makes sense to me, so I imagine we can have best of both worlds with this approach.
Why I am still in favor of a mono-repo is how I imagine the future of Evergreen could play out. It will become easier for people to start adopting evergreen outside of Segment with less sophisticated builds. It is also a sign of maturity of a component library βΒ this might be a biased opinion. Potentially it's cleaner to extend or use certain components when you make a package that says build on top of evergreen-popover
or evergreen-positioner
.
I am happy to reflect back on wether a mono-repo is still the right choice once every while during the coming year(s). But I don't think it is a high priority right now to get rid of it at this point. I do think it's smart to make a evergreen
package that is more accessible and lowers friction of using and adopting evergreen.
Overall I believe in making consumption easy and possible in whatever way possible.
@Rowno can you explain what exactly the mono-repo is overcomplicating? If it's consumption this would solve it right?
from evergreen.
I think all of these components should stay in the same repository (a "monorepo"), but I do not see any benefit of exposing multiple packages (via Lerna). Even "mature" libraries like MaterialUI ship a single package to NPM and let the consumers of the library take what they want from it.
from evergreen.
@stephenmathieson and @Rowno I trust both of you if you guys feel it is the right decision. I don't see it as a high priority right now compared to writing docs and writing more component. If you guys feel different about it and want to take this responsibility I am more than happy to jump on board.
from evergreen.
Closing this in favor of #117
from evergreen.
Related Issues (20)
- Textarea component loses borders under certain conditions
- Property 'children' does not exist on type 'IntrinsicAttributes & TooltipProps'. HOT 4
- SSR with Remix HOT 3
- `SideSheet` prevents page scroll even after closing, when `preventBodyScrolling` set to true HOT 3
- Style of selected tab differs between tab link and basic tab HOT 3
- Property `selected` should include `PropTypes.number` to allow integer values HOT 1
- Can't use (intent) and (type) property at the same time in <Button> component HOT 1
- Badge color should not have 'automatic' in its typing
- Feature request: Tooltip pointer arrow triangle shape (optional) HOT 1
- LinkProps.target should be `HTMLAttributeAnchorTarget | undefined`
- Button disabled icon color doesn't change HOT 2
- Badge no longer shows text if you pass color hex code HOT 8
- CSS modification HOT 1
- Ability to handle overlay/close clicks in Dialog component, onBeforeClose HOT 2
- inputValue.trim is not a function when using object array for items in autocomplete with "allowOtherValues"
- NextJs 13 App Router
- zIndex for Toaster HOT 1
- Toaster CSS Overide
- Project still maintained? HOT 13
- Footer Component Positioning Problem HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evergreen.