Comments (4)
f2prateek
commented on May 31, 2024
Yup unchecked is the default and certainly not needed - though it serves as documentation that we haven't simply overlooked the case.
I was not aware that uint's are not CLS compliant, thanks for bringing it up. I do agree that it is a big deal deal for a library.
I think a good middle ground would be to a) use int and b) handle overflow and reset the counter to 0 when overflow is detected.
What do you all think?
from analytics.net.
Dmitry-Me
commented on May 31, 2024
@f2prateek I guess this is sensible approach yet this will look rather overengineered. Do you want another PR?
from analytics.net.
f2prateek
commented on May 31, 2024
That'd definitely be great, thanks! I do agree the solution won't look pretty - definitely open to other ideas as well.
from analytics.net.
Dmitry-Me
commented on May 31, 2024
@f2prateek @jzebedee Submitted #48
from analytics.net.
Related Issues (20)
- `Defaults` class removed with no way to access values elsewhere HOT 1
- Create config.yml for circle ci in .net solution HOT 1
- Question: Is this suitable for Xamarin integration? HOT 3
- Changing fields of Concrete implementations of BaseAction to Properties HOT 1
- Versioning Question Due to Error HOT 4
- Support for .NET 5.0 framework
- Events not sent to Segment servers: The operation was canceled. HOT 6
- Update e2e CircleCi config due to image problem
- e2e Testing failing in circleci
- AsyncIntervalFlushHandler deadlock HOT 3
- Encounter System.ObjectDisposedException after Dispose is called HOT 3
- Expose Message Id as a configurable option HOT 1
- Snyk.io reports issue with referenced Newtonsoft.Json package HOT 1
- Allow a mocked Client to be used for the Analytics singleton
- Remove dependency on Json.Net HOT 3
- Make it easier to get 'hidden' errors when trying to send data to Segment HOT 1
- Calling Analytics.Client.Flush() when there are pending events can cause deadlock HOT 8
- Why is the NuGet package unlisted? HOT 5
- Analytics.NET Midleware HOT 1
- My event is not being tracked, how do I troubleshoot it? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analytics.net.