Git Product home page Git Product logo

Comments (4)

sefibk avatar sefibk commented on August 11, 2024
  1. Are you sure? did you verify this is right?
  2. Wouldn't your suggestion create multiple copies of the input_image?

from kernelgan.

alexander-rakhlin avatar alexander-rakhlin commented on August 11, 2024

Yes, the difference is view vs copy. Slicing shares data with the original object
https://scipy-cookbook.readthedocs.io/items/ViewsVsCopies.html

Another thing you may implement here is to move self.input_image to GPU at initialization. This should improve speed (but not by much in my case)
crop_im = self.input_image_cuda[top:top + size, left:left + size, :].data.clone()

from kernelgan.

sefibk avatar sefibk commented on August 11, 2024

There are definitely a LOT of things to optimize!
I am only taking care of serious bugs currently, I am no longer in the field of this work...
If you fixed the bug and would like to open a PR I would appreciate the contribution

from kernelgan.

sefibk avatar sefibk commented on August 11, 2024

Thanks for the PR.
I will verify performance is not hurt on the entire dataset and will merge.
It may take me a while to get to it

from kernelgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.