Comments (6)
From what I can see in the original uploader.js code, https://github.com/Seedmanc/Booru-mass-uploader/blob/gh-pages/js/uploader.js#L209 it only shows the "exists" message if server responds with "exists" as well. The problem is in the booru engine itself, upon encountering errors says "image either exists or is corrupted", without differentiating between the issues. It even says so for images that were deleted and uploaded again later.
from booru-mass-uploader.
Upon closer inspection, booru does say somewhat different things depending on the situation and even when it links to a deleted duplicate, the link lacks the ID.
Based on that I improved the error reporting engine, it should now make more sense and even link to true duplicates. Please test.
from booru-mass-uploader.
Great, it works! However it could still be improved a little:
If the image already exists (or previously existed) then it links to either an ID number or no ID number: &id=#
or &id=
(meaning it was deleted). Thus, ": image either already exists or is corrupted." should say "" (nothing), ": generic error.", or ": too big? too small? corrupted?"
Also maybe for when &id=[nothing] the error could display: "image was deleted"
from booru-mass-uploader.
Done.
Say, you wanna be a collaborator here? I see you have to manually repeat my changes in your fork instead of pulling due to differences here and I might lack some booru-related knowledge to resolve proposed issues on my own. I never dealt with collaborations before though, do you have any experience?
Unless you want to continue maintaining your own version of course.
from booru-mass-uploader.
OK, I will collaborate; it will work better that way.
This is my first account on this sort of websites so I don't have much experience; I created this account due to the enthusiasm I had towards seeing the uploader script working again.
from booru-mass-uploader.
Added you as a collaborator, you can contribute here now. Keep in mind though that changes made to files other than the .user.js are live and will be immediately in effect for anyone using the userscript. Maybe eventually I'll figure out how to make a development branch compatible with gh-pages.
Tried to format the codebase and include some of your changes as well. There's probably not much need in putting every basic booru into include list now unless you're using those yourself. Users should be able to do that themselves following the pattern. Once we manage to add support for other engine boorus/modifications of Gelbooru, it would make sense to put examples of those into includes.
from booru-mass-uploader.
Related Issues (20)
- add tags with sidecar tag text file? HOT 7
- Uploader page incorrecly indicates login status with Danbooru HOT 3
- Drawfriends Booru-mass-uploader does not install on new Firefox 57 or upload with files on Chrome HOT 8
- Script doesn't seem to work HOT 3
- It won't upload anything... HOT 9
- For booru owner it shows "posting anonymously" when logged in. HOT 6
- not support arabic tags HOT 2
- Mass uploader button doesn't show up on Draw Friends Booru HOT 2
- *.booru.org also requires https now HOT 3
- add https://hypnohub.net to the list of supported website HOT 1
- Use "Tag list (separate with spaces)" along with "use sidecar files as sources of tags for each image" HOT 2
- Sidecar and upload problem HOT 1
- Sidecar files don't work at Danbooru website. Mass uploader opened in new tab = fail
- Storing the URL of uploaded images HOT 1
- Filenames with spaces are truncated to the last word dot extension HOT 3
- Ultra noob here
- "Error: Check your posting form URL" HOT 7
- SSmstzo HOT 1
- Allow webm/mp4s HOT 2
- [Gelbooru] Mass Uploader page refuses to load HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from booru-mass-uploader.