Git Product home page Git Product logo

Comments (2)

sebholstein avatar sebholstein commented on May 16, 2024

There's a few events that aren't yet covered and am wondering which ones you plan to target? Should we attach to all of the events on here? I'm sure they'd all eventually get requested:

@intellix yeah I fully agree on this: we definitely have to support all the available events.

Currently, there is no way to detect if the developer uses a certain EventEmitter, so I don't see any other way to attach event listeners for all events atm.

Some things to note for implementing new events:

  • On MarkerManager level, some refactoring is needed here:
    marker-manager.ts#L44
    It is not a good way to create a separate method for every event. I did this already for the SebmGoogleMap Component (on Map level) here: google-maps-api-wrapper.ts#L48 - So something similar is needed for the Marker before adding new event listeners.
  • New EventEmitter names should be named in present tense and camel cased:
    Native Google Maps API Event: maptypeid_changed -> EventEmitter name: mapTypeIdChange
  • When there is a native browser event for a Google Maps API Event (for example click), it should get prefixed (to not bind to a native browser event): click -> markerClick
  • For mouse events, we should introduce a new Interface that gets used in Map and Marker Events that are related to mouse events. (There is a MapMouseEvent interface at the moment, but the same interface could also get used in markers: MapMouseEvent

I can PR some of these, but just want to know what you think about it first as you didn't do them yet so maybe have a reason for not including (performance?)

Would be awesome! 😎 Also, I'm happy to discuss all these things I described here.

from angular-google-maps.

sebholstein avatar sebholstein commented on May 16, 2024

Already resolved

from angular-google-maps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.