Comments (2)
There's a few events that aren't yet covered and am wondering which ones you plan to target? Should we attach to all of the events on here? I'm sure they'd all eventually get requested:
@intellix yeah I fully agree on this: we definitely have to support all the available events.
Currently, there is no way to detect if the developer uses a certain EventEmitter, so I don't see any other way to attach event listeners for all events atm.
Some things to note for implementing new events:
- On MarkerManager level, some refactoring is needed here:
marker-manager.ts#L44
It is not a good way to create a separate method for every event. I did this already for the SebmGoogleMap Component (on Map level) here: google-maps-api-wrapper.ts#L48 - So something similar is needed for the Marker before adding new event listeners. - New EventEmitter names should be named in present tense and camel cased:
Native Google Maps API Event:maptypeid_changed
-> EventEmitter name:mapTypeIdChange
- When there is a native browser event for a Google Maps API Event (for example
click
), it should get prefixed (to not bind to a native browser event):click
->markerClick
- For mouse events, we should introduce a new Interface that gets used in Map and Marker Events that are related to mouse events. (There is a MapMouseEvent interface at the moment, but the same interface could also get used in markers: MapMouseEvent
I can PR some of these, but just want to know what you think about it first as you didn't do them yet so maybe have a reason for not including (performance?)
Would be awesome! 😎 Also, I'm happy to discuss all these things I described here.
from angular-google-maps.
Already resolved
from angular-google-maps.
Related Issues (20)
- Is this project dead ? HOT 1
- No Support for Angular 13 HOT 2
- Not getting lat long data from Circle and Rectangle
- No Support for Angular 12 version. HOT 1
- How to grey the Map? HOT 2
- Angular 14 support? HOT 15
- Warning Error
- Can you provide a support to create a Context Menu on Marker Right click.
- agm-polygon path is not getting updated on changes in component.ts file
- click
- fullscreenControl and fullscreenControlOptions is not working as expected
- Blur the map area when a polygon is drawn
- NG 14 support not published HOT 15
- Publish please HOT 2
- In Angular version 16 not working HOT 4
- How to implement data-driven styling based on placeId?
- error TS2314: Generic type 'MapHandlerMap<T>' requires 1 type argument(s). HOT 3
- error in (agm-core.js:299:31) when using @Agm/core
- In Angular-16 gives error
- Angular 16 compatibility? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-google-maps.