code review about angular-google-maps HOT 4 CLOSED

@hlobil Thanks for reviewing the code!

1. 👍 Good catch. I think the tslint.json should contain the no-unused-variable, so this gets checked automaticaly in Travis.
2. 👍 yeah, that's missing. Good catch.
3. No there is no reason. I was confused what's the right package when I started the project. Now I know @reactivatex/rxjs is the right package. The cleanup is an open point on my todo list.

Interested in sending a PR?

from angular-google-maps.

2. is done

from angular-google-maps.

Sorry for not sending a PR. I have had to manually move your library into my project as my understanding of system.js was poor. I will clone and merge all my changes soon.

I have been playing with plunker and may have figured out my issue. In the plunker I noticed that we need (code below), not sure why angular2 library does not need similar syntax?

packages: {
    'angular2_google_maps': {
      defaultExtension: 'js',
    }
  }

from angular-google-maps.

No problem. Yes it's needed because angular2-google-maps uses a newer version of systemJS builder which adds js extensions (angular2 uses an older version, but an update is in progress: #4561).

I'm closing this issue. But feel free to add comments to this. Thanks!

from angular-google-maps.