Git Product home page Git Product logo

Comments (15)

SebastianZaha avatar SebastianZaha commented on July 21, 2024 1

Thanks for the report, seems like this should definitely be addressed. I will install typometer and try to find the cause.

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024 1

Yep, understood. Thanks for all the clarifications, much appreciated, I'm glad I removed that latency-inducing legacy stuff :) !

I'll close this for now, but will remain subscribed to the vscode issue you opened and wait for some devs to chime in.

from vscode-emacs-friendly.

mauro3 avatar mauro3 commented on July 21, 2024

As a side note: below the results for my Emacs setup (i.e. with my .emacs loaded):

emacs
Shows average latency of 5.9ms, max 65ms (just one spike though).

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024

I have found a big culprit here, the old extension had a beginning of an implementation of a register mode which was intercepting typing events. I have removed it as it was causing it too much latency, we'll have to find another implementation.

Could you please re-do the tests on your machine? On mine this got it down 30%.

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024

After updating to 0.8.0 I mean :)

from vscode-emacs-friendly.

mauro3 avatar mauro3 commented on July 21, 2024

Cheers! But how do I install it? I know how to install from VSIX. If from VSIX, how do I make one?

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024

It's published, so from your extensions tab, click "check for updates" and reload the window afterwards.

Sometimes it takes a bit for a new version to show up, if you do not see an update available, perhaps try again in 30 mins or so...

from vscode-emacs-friendly.

mauro3 avatar mauro3 commented on July 21, 2024

Ok, got it. Yes it is better, thanks for looking into this!

The average is now 23ms, here the graph:
vscode-emacs-mode

However, it looks like it is bouncing back and forth between the base value 16ms and slow 33ms. I would think an even 23ms would be better.

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024

I am not sure why but Typometer does not finish when I run it, it always times out with "cannot detect char" at some point. This is on ubuntu / gnome. I tried with osx too and there it seems sometimes it finishes but often does not.

What system are you running it on?

from vscode-emacs-friendly.

mauro3 avatar mauro3 commented on July 21, 2024

Yes, I have that problem with VScode too (not with emacs though). To fix zoom in a lot. Also, I think you need at least one other line which is wider than the screen to make it work. Also, it's recommended to use a non-block cursor but I didn't see any difference there.

I run ArchLinux with xmonad window manager.

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024

It does work when zoomed in and with one line larger than the screen indeed. But runs vary a lot between them, even without any extensions, there are weird spikes, and I don't see a clear indication that enabling the extension is making it worse... Not sure what is going on my system.

from vscode-emacs-friendly.

mauro3 avatar mauro3 commented on July 21, 2024

Have you tried it with emacs or another editor? Do you have some funky window manager like Compiz? Docs recommend to close all other applications, but I didn't and it worked fine.

from vscode-emacs-friendly.

SebastianZaha avatar SebastianZaha commented on July 21, 2024

Yes @ compiz, i think it's in the default ubuntu desktop instalation, I did not change anything this time :)

I will try on OSX as well again, with the zoom in trick.

But the bouncing graph is reproducible for you, right? And does it go away when disabling the extension?

from vscode-emacs-friendly.

mauro3 avatar mauro3 commented on July 21, 2024

Yes, it says Compiz adds 10ms: https://pavelfatin.com/typometer/

Looks pretty good at the moment with less spikes and average down to 15ms
v2
(which is about what I get without extensions)
So, no, not super reproducible, but I think that is expected.

from vscode-emacs-friendly.

laustbn avatar laustbn commented on July 21, 2024

The C-l/recenter addition from me (that already made it in, thanks!) listens for the onDidChangeTextEditorSelection event which triggers every time the cursor position changes. Even though the event handler only sets a flag, I suppose it could contribute to the spikes.

Personally the lag in the old release wasn't noticeable or bothersome to me. Growing up using remote terminals over a modem may have left a mark... :)

from vscode-emacs-friendly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.