Git Product home page Git Product logo

Comments (4)

MajorCaiger avatar MajorCaiger commented on August 30, 2024

Hi all

I just temporarily reverted my changes locally and the tests still fail. Interestingly, I changed the composer versions of some dependencies, back to a previous version that should be supported, and the test still failed, but with a different output.

Also, on my fork of the repo, the tests were running fine back when I submitted, but now seem to fail after I have composer updated. Could this be related to changes in one of the dependencies? Unfortunately I don't know what the previous versions I was using are.

from phpcov.

MajorCaiger avatar MajorCaiger commented on August 30, 2024

HI all

I have just checked out the last commit prior to any of our changes, updates composer and ran the tests.

There are the same failures appearing (See below).

~/Development/Projects/phpcov (master) -> git checkout b890e390724be2ae18189ddd5e717d03f77f0299
Note: checking out 'b890e390724be2ae18189ddd5e717d03f77f0299'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b890e39... "symfony/finder": "~2.2" -> "symfony/finder": "~2|~3"
-----------------------------------------------------------
~/Development/Projects/phpcov ((b890e39...)) -> composer update
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Generating autoload files
-----------------------------------------------------------
~/Development/Projects/phpcov ((b890e39...)) -> phpunit -c build
PHPUnit 4.8.21 by Sebastian Bergmann and contributors.

F

Time: 70 ms, Memory: 5.75Mb

There was 1 failure:

1) SebastianBergmann\PHPCOV\PatchCoverageTest::testPatchCoverageIsCalculatedCorrectly
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    'numChangedLinesThatAreExecutable' => 2
-    'numChangedLinesThatWereExecuted' => 1
+    'numChangedLinesThatAreExecutable' => 0
+    'numChangedLinesThatWereExecuted' => 0
     'changedLinesThatWereNotExecuted' => Array (
-        'Example.php' => Array (...)
     )
 )

/Users/rob/Development/Projects/phpcov/tests/PatchCoverageTest.php:37
phar:///usr/local/bin/phpunit/phpunit/TextUI/Command.php:179
phar:///usr/local/bin/phpunit/phpunit/TextUI/Command.php:132

FAILURES!
Tests: 1, Assertions: 1, Failures: 1.

My guess is that these failures are due to changes in a composer dependency. I can attempt to narrow it down, but it may take some time. @sebastianbergmann Maybe you could shed a little light?

Thanks

Rob

from phpcov.

MajorCaiger avatar MajorCaiger commented on August 30, 2024

Actually....

What I said isn't correct.

For the tests to run, you need to create a file called /tmp/example/Example.php then all tests run correctly.

After doing this locally, all tests run and pass.

I remember getting stuck at this point while I was making my changes.

~/Development/Projects/phpcov {master} -> touch /tmp/example/Example.php
-----------------------------------------------------------
~/Development/Projects/phpcov {master} -> phpunit -c build
PHPUnit 4.8.21 by Sebastian Bergmann and contributors.

...

Time: 70 ms, Memory: 5.50Mb

OK (3 tests, 3 assertions)

Thanks

Rob

from phpcov.

sebastianbergmann avatar sebastianbergmann commented on August 30, 2024

Cannot reproduce this anymore.

from phpcov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.