Mapper::stringToCodeUnits() breaks when ClassName<extended> is used for class that extends built-in class about code-unit HOT 3 CLOSED

Annotations such as @covers ClassName<extended> are deprecated since PHPUnit 9.0 and support for them will be removed in PHPUnit 10.0.

That being said, they should still work in PHPUnit 9.x.

from code-unit.

The documentation for @covers ClassName<extended> reads:

Specifies that the annotated test method covers all methods of a given class and its parent class(es).

HydratorAwareTrait is a trait, not a class. @covers Laminas\Hydrator\HydratorAwareTrait<extended> makes no sense and is not documented to work.

It is unfortunate that PHPUnit did not complain about this mistake in the past. I may consider a pull request for code-unit (which is the component that parses strings such as @covers ClassName<extended>) that lets PHPUnit accept this pointless annotation again. But I will not invest any time into this myself.

from code-unit.

@sebastianbergmann

Sorry, but the same issue we are getting on classes, not on traits:

https://github.com/laminas/laminas-hydrator/blob/d412da192b4ab70e6c80acda8f420f3b26a94793/test/Iterator/HydratingIteratorIteratorTest.php#L20-L23

https://github.com/laminas/laminas-hydrator/blob/d412da192b4ab70e6c80acda8f420f3b26a94793/src/Iterator/HydratingIteratorIterator.php#L22

I can agree with traits, as documentation does not specify that, but ignoring the issue for the classes is ignoring semver and reported BC Break in the library.

from code-unit.