Convert servicelogger.mix to servicelogger.py about nodemanager HOT 10 CLOSED

Author: justinc
It's not that trivial. Repy uses the service logger and repy can't use repyhelper without losing all of the restrictions (this is one of the things repyhelper does).

We'd have to patch repyhelper and / or repy to make this work.

from nodemanager.

Author: justinc
This is non-trivial even with a fix to #588. I'm working on it.

from nodemanager.

Author: justinc
My fix is blocked / not working because of circular imports. These should be avoided if at all possible. I'm sorting this out now.

from nodemanager.

Author: justinc
(In #590) This is a significant problem. It makes it nearly impossible to fix #586.

from nodemanager.

Author: cemeyer
Status update: this is trivial once #590 is complete.

from nodemanager.

Author: vijay
Accomplished the task of converting servicelogger.mix to servicelogger.py in the r5215

from nodemanager.

Author: vijay
Fixed in r5215

from nodemanager.

Author: monzum
Can this ticket be closed now? I noticed that there is now a servicelogger.py that exists in the repo. The last comment also states that it was fixed.

from nodemanager.

Author: albert
Per r7133:

./branches/nacl_repy/nodemanager/servicelogger.mix
./branches/nacl_repy/repy/servicelogger.py
./branches/repy_v2/nodemanager/servicelogger.py
./branches/repy_v2/repy/repyV1/servicelogger.py
./trunk/nodemanager/servicelogger.mix

At the time of writing, Seattle production is still running RepyV1 and thus has servicelogger.mix. Once we push RepyV2, it will be gone. We won't be converting it before the push.

from nodemanager.

Closing as WONTFIX. https://github.com/SeattleTestbed/nodemanager/blob/master/servicelogger.py is the relevant version for all future releases; I don't see us modifying the V1 nodemanager in this aspect before the switch to V2.

from nodemanager.