Git Product home page Git Product logo

Comments (7)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Fixed in Seaside-Squeak-Kom-jf.24

Original comment by [email protected] on 26 Jun 2008 at 1:42

  • Added labels: ****
  • Removed labels: ****

Attachments:

from seaside.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Here's a test case...

Original comment by [email protected] on 26 Jun 2008 at 2:02

  • Added labels: ****
  • Removed labels: ****

Attachments:

from seaside.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Wow, good catch. There is one problem with you fix though,
#unescapePercentsWithTextEncoding: is available starting with Squeak 3.9 only. 
In
general we tried to be compatible with Squeak 3.8 and Squeak 3.7 mainly because
DabbleDB probably still uses Squeak 3.7.
http://blog.dabbledb.com/2008/07/nuts-bolts.html

For Seaside 2.8 we made a compatibility package (SeasideSqueak37). One option 
is that
we make something like this as well for Squeak 3.8

String >> #unescapePercentsWithTextEncoding: ignored
    ^ self #unescapePercents

or that we reimplement it from scracth. 

I also updated WAUrlEncodingFunctionalTest so that is should really catch this 
issue now.

This is actually a duplicate of: 
http://code.google.com/p/seaside/issues/detail?id=79
and we didn't know it.

Original comment by [email protected] on 12 Jul 2008 at 6:09

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

from seaside.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024

Original comment by [email protected] on 12 Jul 2008 at 6:12

  • Added labels: ****
  • Removed labels: ****

from seaside.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Seems a shame to re-implement from scratch. You're more familiar with the
compatibility and encoding stuff though so I leave the decision to you.

Also I'm not sure how you had these compatibility packages named, setup, etc. 
so if
you want me to actually implement that you'll have to provide more details.

Original comment by [email protected] on 5 Aug 2008 at 2:09

  • Added labels: ****
  • Removed labels: ****

from seaside.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
SeasideSqueak38-pmm.1

Maybe Seaside-Squeak38 or Seaside-Compatiblity-Squeak38 would have been better. 
If
anybody has an problem with the package name, please rename it (and delete the
current one).

As the method comment says, it works only if the argument is null. IIRC there 
were
also some Mantis issues about this method fixed in Squeak 3.9. But it is the 
same
experience you get with Seaside 2.8 on Squeak 3.8.

So as far as I'm concerned this bug can be closed.

Original comment by [email protected] on 5 Aug 2008 at 5:37

  • Added labels: ****
  • Removed labels: ****

from seaside.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024

Original comment by [email protected] on 6 Aug 2008 at 2:53

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

from seaside.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.