Comments (6)
The issue is in this line:
The colors will only show up if a given company has a category of questions (e.g. heap) that has a frequency of at least three. I tested this with Airbnb by adding the company and the "Heap" pattern to the first question in questions.json (Contains Duplicate), and the colors immediately show for all of them.
How do we want the colors to be in these cases?
from leetcode-patterns.
Steps to reproduce:
- Select any company from the dropdown list under
Companies
- Observe the pills under
Problems pattern frequency
Possibly related to either https://github.com/seanprashad/leetcode-patterns/pull/214/files#diff-9aa6b25aa4aab24215ebcedc56e0ff3c2a2e481a30b42eb3ca0fcce2c7752789R402 or #227
from leetcode-patterns.
One problem that I see here is from a UX perspective - the colouring is also used in the Difficulty
column to denote Easy/Medium/Hard questions.
Here, we use the same colour schema, but for a different purpose:
leetcode-patterns/src/components/PatternFrequencies/index.js
Lines 31 to 35 in bdbb042
Since we have two different contexts, we should look into a better colouring scheme when revisiting this!
from leetcode-patterns.
More breadcrumbs:
from leetcode-patterns.
Looks like some companies, like Apple
, show up correctly:
from leetcode-patterns.
How do we want the colors to be in these cases?
Hmm well, I'm not sure to be honest. Ideally, I think some sort of coloured gradient would look nice, where a darker shade maps to a pattern that is more frequent. There's a bunch of websites to help do the CSS, like https://coolors.co/gradient-maker.
Edit: On second thought, let's choose something easy - red if the frequency is >=5 and orange for everything else. We can fiddle around with an appropriate colour scheme after fixing this bug!
from leetcode-patterns.
Related Issues (20)
- Ensure GitHub Pages redeploys after scheduled run-cron job HOT 3
- [Ongoing] Add missing company icons HOT 1
- Website is down HOT 5
- Switching order of reverse linkedlist and palindrome linkedlist? HOT 2
- Patterns HOT 1
- Add lists feature HOT 1
- how do i get started using this repository on my local machine? HOT 1
- Project set up instructions HOT 2
- Add "283. Move Zeroes" to "Two pointers" HOT 3
- Design Gurus & original author acknowledgements HOT 1
- "Backtracking" missing problems HOT 1
- "Sliding Window" missing problems HOT 2
- "Fast & Slow Pointers" missing problems HOT 1
- "Two Pointers" missing problems
- There are two same type of dropDown items in dropDown HOT 1
- "Intervals" missing problems
- Amazon/Facebook don't ask DP problems
- Tips page UI improvement HOT 1
- The need for an authentication system. HOT 1
- SortBy Company field should consider company filter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leetcode-patterns.