Git Product home page Git Product logo

Comments (4)

enekomartinmartinez avatar enekomartinmartinez commented on August 22, 2024

Hi @cdigenna

Thank you for opening the issue, it seems to be a bug in our code.

Our Smooth class doesn't need the delay_time to be initialized. However, it is set as a dependency, so the initialization crashes as delay_time needs the output of the same object. Just removing the dependency in initialization should solve the issue, I am working on that.

from pysd.

enekomartinmartinez avatar enekomartinmartinez commented on August 22, 2024

The changes in https://github.com/SDXorg/pysd/tree/fix_smooth_initial_dependencies should fix the bug.

If everything works well, I will do a minor release, as I am not planning to have other fixes or features soon.

If you could test it, it would be very nice.

from pysd.

cdigenna avatar cdigenna commented on August 22, 2024

Hi @enekomartinmartinez ,

I just tested the change you made, and everything works as expected now! Thank you so much for fixing this :)

-Cathy

from pysd.

enekomartinmartinez avatar enekomartinmartinez commented on August 22, 2024

Great, I already made a minor release, which should be already available in PyPI and soon in conda-forge.

from pysd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.